From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode()
Date: Thu, 5 Sep 2013 17:00:17 +0300 [thread overview]
Message-ID: <20130905140017.GD11428@intel.com> (raw)
In-Reply-To: <1378388444-16149-1-git-send-email-damien.lespiau@intel.com>
On Thu, Sep 05, 2013 at 02:40:44PM +0100, Damien Lespiau wrote:
> >From the copy and paste of drm_crtc_convert_to_umode()'s kerneldoc,
> forgetting to update the symbol name (and they look so similar!).
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Although maybe renaming to drm_crtc_convert_from_umode() might make the
difference easier to spot. But it's only used in one place only so it's
not a big deal.
> ---
> drivers/gpu/drm/drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index e92de2e..81046be 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -1290,7 +1290,7 @@ static void drm_crtc_convert_to_umode(struct drm_mode_modeinfo *out,
> }
>
> /**
> - * drm_crtc_convert_to_umode - convert a modeinfo into a drm_display_mode
> + * drm_crtc_convert_umode - convert a modeinfo into a drm_display_mode
> * @out: drm_display_mode to return to the user
> * @in: drm_mode_modeinfo to use
> *
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2013-09-05 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 13:40 [PATCH] drm: Fix kerneldoc of drm_crtc_convert_umode() Damien Lespiau
2013-09-05 14:00 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905140017.GD11428@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.