From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] usb: gadget: Fix data aborts during USB ethernet boot
Date: Thu, 5 Sep 2013 15:46:35 +0200 [thread overview]
Message-ID: <201309051546.35642.marex@denx.de> (raw)
In-Reply-To: <5227DEF0.80208@atmel.com>
Dear Bo Shen,
> Hi Joel Fernandes,
>
> On 09/05/2013 07:55 AM, Joel Fernandes wrote:
> > As seen on GCC 4.6 Linaro compiler, control_req buffer is not aligned
> > on 4 byte boundaray causing data aborts in eth_setup -> conf_buf
> > during dhcp boot over usb_ether. Fix the issue my aligning control_req
> > buffer using DEFINE_CACHE_ALIGN_BUFFER.
> >
> > Tested on am335x_evm platform (beaglebone).
> > Applies on 2013.10-rc1 branch.
> >
> > Cc: Tom Rini <trini@ti.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Signed-off-by: Joel Fernandes <joelf@ti.com>
> > ---
> >
> > v2 changes:
> > - Using DEFINE_CACHE_ALIGN_BUFFER macro for the alignment.
> > - Also fixed alignment for status_req.
> >
> > v3 changes:
> > - Adjusted commit message for v2 change.
> >
> > drivers/usb/gadget/ether.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Test on sama5d3xek board with RNDIS gadget, it still has the unaligned
> access issue.
>
> However, I test with this patch "usb: gadget: config: fix unaligned
> access issues" from: Troy Kisky <troy.kisky@boundarydevices.com> really
> fix the unaligned access issue.
>
> more information at: http://patchwork.ozlabs.org/patch/264151/
Troy, care to fix up the patch's commit log so I can try and understand it?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-05 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 23:55 [U-Boot] [PATCH v3] usb: gadget: Fix data aborts during USB ethernet boot Joel Fernandes
2013-09-05 1:31 ` Bo Shen
2013-09-05 13:46 ` Marek Vasut [this message]
2013-09-05 15:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309051546.35642.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.