All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Avi <avi.kp.137@gmail.com>
Cc: klmckinney1@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)
Date: Thu, 5 Sep 2013 09:01:17 -0700	[thread overview]
Message-ID: <20130905160117.GA1582@kroah.com> (raw)
In-Reply-To: <20130905155154.GA7535@avi-VPCCW15FG>

On Thu, Sep 05, 2013 at 09:21:54PM +0530, Avi wrote:

> >From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
> From: AVI <avi@avi-VPCCW15FG.(none)>

Why have you attached your patch?  And this "From:" line is obviously
wrong :(

> Date: Thu, 5 Sep 2013 21:03:45 +0530
> Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)"
>  should be "(foo *)" 
> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

You need to put some type of description in the changelog section.

And a new line before the signed-off-by: line.

Can you just use git send-email to send the patch, and not attach it, so
that I don't have to hand-edit the patch in order to apply it properly?

thanks,

greg k-h

  reply	other threads:[~2013-09-05 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 15:51 drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *) Avi
2013-09-05 16:01 ` Greg Kroah-Hartman [this message]
2013-09-05 16:32 ` Dan Carpenter
2013-09-05 16:36   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905160117.GA1582@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=avi.kp.137@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=klmckinney1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.