From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: kirkwood: change the compatible string of the kirkwood-i2s driver Date: Thu, 5 Sep 2013 18:54:56 +0200 Message-ID: <20130905185456.175f556b@armhf> References: <1378385791-29551-1-git-send-email-thomas.petazzoni@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by alsa0.perex.cz (Postfix) with ESMTP id 93189261A1F for ; Thu, 5 Sep 2013 18:53:48 +0200 (CEST) In-Reply-To: <1378385791-29551-1-git-send-email-thomas.petazzoni@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Thomas Petazzoni Cc: Lior Amsalem , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Russell King , Takashi Iwai , Liam Girdwood , Rob Herring , Mark Brown , Ezequiel Garcia , Gregory Clement , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gVGh1LCAgNSBTZXAgMjAxMyAxNDo1NjozMSArMDIwMApUaG9tYXMgUGV0YXp6b25pIDx0aG9t YXMucGV0YXp6b25pQGZyZWUtZWxlY3Ryb25zLmNvbT4gd3JvdGU6Cgo+IFRoZSBjb21wYXRpYmxl IHN0cmluZyBvZiB0aGUga2lya3dvb2QtaTJzIGRyaXZlciB3YXMgY2hvc2VuIGFzCj4gIm1hcnZl bGwsbXZlYnUtYXVkaW8iLiBVc2luZyBzdWNoIGEgY29tcGF0aWJsZSBzdHJpbmcgaXMgbm90IGEg Z29vZAo+IGlkZWEsIHNpbmNlICJtdmVidSIgaXMgdGhlIG5hbWUgb2YgYSBsYXJnZSBmYW1pbHkg b2YgU09DcywgaW4gd2hpY2gKPiBuZXcsIHVua25vd24gU09DcyB3aWxsIGJlIGNvbWluZyBpbiB0 aGUgZnV0dXJlLiBJdCBpcyB0aGVyZWZvcmUKPiBpbXBvc3NpYmxlIHRvIGtub3cgd2hhdCB3aWxs IGJlIGV2b2x1dGlvbnMgb2YgdGhpcyBoYXJkd2FyZSBibG9jayBpbgo+IHRoZSBuZXh0IGdlbmVy YXRpb25zIG9mIHRoZSBTT0NzLiBGb3IgdGhpcyByZWFzb24sIHRoZSByZWNvbW1hbmRhdGlvbgo+ IGZvciBjb21wYXRpYmxlIHN0cmluZ3Mgb2Ygb24tU09DcyBkZXZpY2VzIGhhcyBhbHdheXMgYmVl biB0byB1c2UgdGhlCj4gbmFtZSBvZiB0aGUgb2xkZXN0IFNPQyB0aGF0IGhhcyB0aGUgaGFyZHdh cmUgYmxvY2suIE5ldyBTT0NzIHRoYXQgaGF2ZQo+IGFuIGV4YWN0bHkgY29tcGF0aWJsZSBoYXJk d2FyZSBibG9jayBjYW4gcmVmZXJlbmNlIGl0IHVzaW5nIHRoZSBzYW1lCj4gY29tcGF0aWJsZSBz dHJpbmcuIFNlZSBbMV0sIFsyXSBhbmQgWzNdIGZvciB2YXJpb3VzIGNhc2VzIHdlcmUgdGhpcwo+ IHN1Z2dlc3Rpb24gd2FzIG1hZGUsIGluY2x1ZGluZyBmcm9tIFJvYiBIZXJyaW5nLCBhIERldmlj ZSBUcmVlIGJpbmRpbmcKPiBtYWludGFpbmVyLgo+IAo+IEFzIGFuIGV4YW1wbGUsIHRoZXJlIGFy ZSBhbHJlYWR5IHNtYWxsIGRpZmZlcmVuY2VzIGJldHdlZW4gY3VycmVudAo+IGdlbmVyYXRpb25z Ogo+IAo+ICAqIE9uIEtpcmt3b29kLCBvbmx5IG9uZSBpbnRlcnJ1cHQgaXMgdXNlZCBmb3IgYXVk aW8uCj4gICogT24gRG92ZSwgdHdvIGludGVycnVwdHMgYXJlIHVzZWQsIG9uZSBmb3IgYXVkaW8g ZGF0YSBhbmQgb25lIGZvcgo+ICAgIGVycm9yIHJlcG9ydGluZy4KPiAKPiBJbiB0aGUgbmVhciBm dXR1cmUsIEknbGwgYmUgYWRkaW5nIGF1ZGlvIHN1cHBvcnQgdG8gQXJtYWRhIDM3MCwgd2hpY2gK PiBhbGxvd3MgaGFzIHRoZSBzYW1lIGhhcmR3YXJlIGJsb2NrIChidXQgbWF5YmUgd2l0aCBtaW5v ciB2YXJpYW50cykuCj4gCj4gVGhlcmVmb3JlLCB0aGlzIHBhdGNoIGNoYW5nZXMgdGhlIGRyaXZl ciB0byBhY2NlcHQKPiAibWFydmVsbCxraXJrd29vZC1hdWRpbyIgYW5kICJtYXJ2ZWxsLGRvdmUt YXVkaW8iIGFzIGNvbXBhdGlibGUKPiBzdHJpbmdzIGluc3RlYWQgb2YgdGhlIHRvby1nZW5lcmlj ICJtYXJ2ZWxsLG12ZWJ1LWF1ZGlvIi4gVGhlIHJlYXNvbgo+IGZvciB0aGUgdHdvIGRpZmZlcmVu dCBjb21wYXRpYmxlIHN0cmluZ3MgaXMgdGhlIGRpZmZlcmVuY2UgaW4gdGhlCj4gbnVtYmVyIG9m IGludGVycnVwdHMgdXNlZCBieSB0aGUgdHdvIFNPQ3MgZm9yIGF1ZGlvLgo+IAo+IFRoaXMgRGV2 aWNlIFRyZWUgYmluZGluZyBoYXMgbmV2ZXIgYmVlbiBwYXJ0IG9mIGEgTGludXgga2VybmVsIHN0 YWJsZQo+IHJlbGVhc2Ugc28gZmFyLCBzbyBpdCBjYW4gYmUgY2hhbmdlZCBub3cgd2l0aG91dCBi cmVha2luZyBiYWNrd2FyZAo+IGNvbXBhdGliaWxpdHkuCj4gCj4gWzFdIGh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL3BpcGVybWFpbC9saW51eC1tdGQvMjAxMi1NYXJjaC8wNDA0MTcuaHRtbAo+ IFsyXSBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9waXBlcm1haWwvbGludXgtYXJtLWtlcm5l bC8yMDEzLUFwcmlsLzE2MTA2NS5odG1sCj4gWzNdIGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L3BpcGVybWFpbC9saW51eC1hcm0ta2VybmVsLzIwMTItTWFyY2gvMDg3NzAyLmh0bWwKPiAKPiBT aWduZWQtb2ZmLWJ5OiBUaG9tYXMgUGV0YXp6b25pIDx0aG9tYXMucGV0YXp6b25pQGZyZWUtZWxl Y3Ryb25zLmNvbT4KPiAtLS0KClRoZSBuYW1lIG9mIHRoZSBraXJ3b29kIGF1ZGlvIGRyaXZlciBo YXMgYmVlbiBjaGFuZ2VkIGZyb20KImtpcmt3b29kLWkycyIgdG8gIm12ZWJ1LWF1ZGlvIiBieSBS dXNzZWxsIEtpbmcKKGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvYXJtLWtlcm5lbC9tc2cy NjQxODUuaHRtbCkuCkkgaGF2ZSBqdXN0IHVzZWQgdGhpcyBuYW1lIGluIHRoZSBEVC4KClRoZW4s IHRoZSBzZWNvbmQgaW50ZXJydXB0IGluIERvdmUgaXMgbm90IHVzZWQgaW4gdGhlIGRyaXZlci4g SWYgaXQKc2hvdWxkLCBpdCB3b3VsZCBiZSBwcmVzZW50IGluIHRoZSBEVHMgb2YgdGhlIGRvdmUg Ym9hcmRzIG9ubHksIHNvLAphY3R1YWxseSwgdGhlcmUgaXMgbm90IG5lZWQgdG8gaGF2ZSBkaWZm ZXJlbnQgY29tcGF0aWJsZXMuCgpFdmVudHVhbGx5LCB5b3UgYXJlIHRhbGtpbmcgYWJvdXQgc29t ZSBvdGhlciBtdmVidSBTb0NzLiBCZWZvcmUgYWRkaW5nCmFueSBuZXcgY29tcGF0aWJsZSwgaXQg d291bGQgYmUgbmljZSB0byBrbm93IGlmLCBmb3IgZXhhbXBsZSwgc29tZQpjaGFuZ2VzIGFyZSBu ZWVkZWQgaW4gdGhlIGtpcmt3b29kL2RvdmUgYXVkaW8gZHJpdmVyIGZvciB0aGUgQXJtYWRhIDM3 MC4uLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRh diEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNh LWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 5 Sep 2013 18:54:56 +0200 Subject: [PATCH] ASoC: kirkwood: change the compatible string of the kirkwood-i2s driver In-Reply-To: <1378385791-29551-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1378385791-29551-1-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <20130905185456.175f556b@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 5 Sep 2013 14:56:31 +0200 Thomas Petazzoni wrote: > The compatible string of the kirkwood-i2s driver was chosen as > "marvell,mvebu-audio". Using such a compatible string is not a good > idea, since "mvebu" is the name of a large family of SOCs, in which > new, unknown SOCs will be coming in the future. It is therefore > impossible to know what will be evolutions of this hardware block in > the next generations of the SOCs. For this reason, the recommandation > for compatible strings of on-SOCs devices has always been to use the > name of the oldest SOC that has the hardware block. New SOCs that have > an exactly compatible hardware block can reference it using the same > compatible string. See [1], [2] and [3] for various cases were this > suggestion was made, including from Rob Herring, a Device Tree binding > maintainer. > > As an example, there are already small differences between current > generations: > > * On Kirkwood, only one interrupt is used for audio. > * On Dove, two interrupts are used, one for audio data and one for > error reporting. > > In the near future, I'll be adding audio support to Armada 370, which > allows has the same hardware block (but maybe with minor variants). > > Therefore, this patch changes the driver to accept > "marvell,kirkwood-audio" and "marvell,dove-audio" as compatible > strings instead of the too-generic "marvell,mvebu-audio". The reason > for the two different compatible strings is the difference in the > number of interrupts used by the two SOCs for audio. > > This Device Tree binding has never been part of a Linux kernel stable > release so far, so it can be changed now without breaking backward > compatibility. > > [1] http://lists.infradead.org/pipermail/linux-mtd/2012-March/040417.html > [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/161065.html > [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/087702.html > > Signed-off-by: Thomas Petazzoni > --- The name of the kirwood audio driver has been changed from "kirkwood-i2s" to "mvebu-audio" by Russell King (http://www.spinics.net/lists/arm-kernel/msg264185.html). I have just used this name in the DT. Then, the second interrupt in Dove is not used in the driver. If it should, it would be present in the DTs of the dove boards only, so, actually, there is not need to have different compatibles. Eventually, you are talking about some other mvebu SoCs. Before adding any new compatible, it would be nice to know if, for example, some changes are needed in the kirkwood/dove audio driver for the Armada 370... -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/