From: Amit Shah <amit.shah@redhat.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_pci: pm: Use CONFIG_PM_SLEEP instead of CONFIG_PM
Date: Fri, 6 Sep 2013 13:37:44 +0530 [thread overview]
Message-ID: <20130906080744.GD29367@grmbl.mre> (raw)
In-Reply-To: <52293DD4.6050403@intel.com>
On (Fri) 06 Sep 2013 [10:28:36], Aaron Lu wrote:
>
> The virtio_pci_freeze/restore are defined under CONFIG_PM but is used
> by SET_SYSTEM_SLEEP_PM_OPS macro, which is defined under
> CONFIG_PM_SLEEP. So if CONFIG_PM_SLEEP is not cofigured but
> CONFIG_PM_RUNTIME is, the following warning message appeared:
>
> drivers/virtio/virtio_pci.c:770:12: warning: ‘virtio_pci_freeze’ defined but not used [-Wunused-function]
> static int virtio_pci_freeze(struct device *dev)
> ^
> drivers/virtio/virtio_pci.c:790:12: warning: ‘virtio_pci_restore’ defined but not used [-Wunused-function]
> static int virtio_pci_restore(struct device *dev)
> ^
> Fix it by changing CONFIG_PM to CONFIG_PM_SLEEP.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2013-09-06 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 2:28 [PATCH] virtio_pci: pm: Use CONFIG_PM_SLEEP instead of CONFIG_PM Aaron Lu
2013-09-06 7:20 ` Amit Shah
2013-09-06 7:41 ` Aaron Lu
2013-09-06 7:41 ` Aaron Lu
2013-09-06 8:07 ` Amit Shah
2013-09-06 8:07 ` Amit Shah [this message]
2013-09-09 0:33 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2013-09-06 2:28 Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906080744.GD29367@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=aaron.lu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.