From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Waiman Long <Waiman.Long@hp.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
"Norton, Scott J" <scott.norton@hp.com>,
George Spelvin <linux@horizon.com>,
John Stoffel <john@stoffel.org>
Subject: Re: [PATCH v3 1/1] dcache: Translating dentry into pathname without taking rename_lock
Date: Sat, 7 Sep 2013 19:53:51 +0100 [thread overview]
Message-ID: <20130907185351.GF13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130907180724.GE13318@ZenIV.linux.org.uk>
On Sat, Sep 07, 2013 at 07:07:24PM +0100, Al Viro wrote:
> with these loops turning into
> seq = read_seqlock(&rename_lock);
again:
> ...
> if (!seqretry_and_lock(&rename_lock, &seq))
> goto again;
> ...
> seqretry_done(&rename_lock);
Forgot the label, sorry.
And I agree that d_lookup() ought to stay as is - this is just about
the ones that try readlock once and then fall back to writer.
next prev parent reply other threads:[~2013-09-07 18:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 16:08 [PATCH v3 0/1] dcache: Translating dentry into pathname without taking rename_lock Waiman Long
2013-09-06 16:08 ` [PATCH v3 1/1] " Waiman Long
2013-09-06 20:52 ` Linus Torvalds
2013-09-06 21:05 ` Al Viro
2013-09-06 21:48 ` Linus Torvalds
2013-09-07 0:00 ` Al Viro
2013-09-07 0:19 ` Linus Torvalds
2013-09-07 0:58 ` Linus Torvalds
2013-09-07 3:01 ` Al Viro
2013-09-07 17:32 ` Al Viro
2013-09-08 4:15 ` Ian Kent
2013-09-08 4:58 ` Al Viro
2013-09-08 8:51 ` Ian Kent
2013-09-07 17:52 ` Linus Torvalds
2013-09-07 18:07 ` Al Viro
2013-09-07 18:53 ` Al Viro [this message]
2013-09-09 14:31 ` Waiman Long
2013-09-07 2:24 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130907185351.GF13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Waiman.Long@hp.com \
--cc=aswin@hp.com \
--cc=john@stoffel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=scott.norton@hp.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.