From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef Date: Sun, 8 Sep 2013 20:36:30 +0100 Message-ID: <20130908193629.GA31384@strange.amr.corp.intel.com> References: <1378493845-476-1-git-send-email-damien.lespiau@intel.com> <1378493845-476-4-git-send-email-damien.lespiau@intel.com> <20130908115829.GW27291@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 79448E657A for ; Sun, 8 Sep 2013 12:36:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130908115829.GW27291@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, Sep 08, 2013 at 01:58:29PM +0200, Daniel Vetter wrote: > On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote: > > Just for consistency. > > > > Signed-off-by: Damien Lespiau > > Afaik kernel coding style is to echew typdefs for normal structures as > much as possible. The only exception is for truly opaque types used in > abstractions, like dma_addr_t or pid_t. > > All the typedefs we still have here go back to the old days of a drm core > shared between *bsd and linux. Since that's long gone they imo should all > die, but certainly we shouldn't add new ones. I figured that since we where talking about user space API, the kernel rules wouldn't apply there and we could have some consistency, but I certainly can just drop those patches. -- Damien