All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Peng Tao <tao.peng@emc.com>, Peng Tao <bergwolf@gmail.com>
Subject: Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA
Date: Sun, 8 Sep 2013 19:31:52 -0700	[thread overview]
Message-ID: <20130909023152.GA5329@kroah.com> (raw)
In-Reply-To: <522D3153.5000102@roeck-us.net>

On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote:
> On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
> > On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
> >> mips allmodconfig fails with
> >>
> >> ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> >> undefined!
> >>
> >> which is due to LUSTRE using copy_from_user_page which is not exported by any
> >> architecture.
> >
> > Any, or just these arches?
> >
> Other architectures implement it as define as far as I can see.

Then why would it be a problem?

> >> Unfortunately, LUSTRE can only be built as module, so there is no
> >> easy fix.
> >
> > Can't we just export the functions for those arches?  Surely lutre
> > isn't the first/only driver that needs this?
> >
> That would be another option.
> 
> Actually, turns out Geert submitted a patch to do this for mips already, and Ralf applied it:
> 
> https://lkml.org/lkml/2013/9/5/111
> 
> So please forget this patch. If sh/xtensa actually need it, we can do the same there.

Sounds good to me, consider it forgotten :)

greg k-h

  reply	other threads:[~2013-09-09  2:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09  1:03 [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA Guenter Roeck
2013-09-09  1:59 ` Greg Kroah-Hartman
2013-09-09  2:18   ` Ramkumar Ramachandra
2013-09-09  2:33     ` Greg Kroah-Hartman
2013-09-09  2:38       ` Ramkumar Ramachandra
2013-09-09  2:50         ` Greg Kroah-Hartman
2013-09-09  2:55           ` Ramkumar Ramachandra
2013-09-09  3:21             ` Guenter Roeck
2013-09-09  3:38               ` Ramkumar Ramachandra
2013-09-09  2:24   ` Guenter Roeck
2013-09-09  2:31     ` Greg Kroah-Hartman [this message]
2013-09-09  2:31       ` Guenter Roeck
2013-09-09  5:01         ` Heiko Carstens
2013-09-10 17:14           ` Peng Tao
2013-09-11  1:44             ` Christoph Hellwig
2013-09-11  2:25               ` Peng Tao
2013-09-11  2:30                 ` Guenter Roeck
2013-09-11  2:51                   ` Peng Tao
2013-09-11 16:29                     ` Christoph Hellwig
2013-09-11 21:23                       ` Dilger, Andreas
2013-09-11 20:48                 ` Dilger, Andreas
2013-09-12  8:01                   ` Peng Tao
2013-09-09 13:40   ` Christoph Hellwig
2013-09-09 16:39     ` Greg Kroah-Hartman
2013-09-09 17:08       ` Guenter Roeck
2013-09-09 17:22         ` Greg Kroah-Hartman
2013-09-09 19:11           ` Geert Uytterhoeven
2013-09-09 20:06             ` Guenter Roeck
2013-09-10  8:49               ` Geert Uytterhoeven
2013-09-10 16:44                 ` Guenter Roeck
2013-09-10 16:51                   ` Geert Uytterhoeven
2013-09-10 17:15                 ` Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909023152.GA5329@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tao.peng@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.