From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's priority field to accept negative values
Date: Mon, 9 Sep 2013 14:48:55 +0300 [thread overview]
Message-ID: <20130909114855.GF31476@redhat.com> (raw)
In-Reply-To: <CAFEAcA-=SjR4mnU-U_-3duwyYocBjTg=CeiWsCE=Eq=sDCEdmA@mail.gmail.com>
On Mon, Sep 09, 2013 at 12:45:12PM +0100, Peter Maydell wrote:
> On 9 September 2013 12:41, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Mon, Sep 09, 2013 at 02:21:35PM +0300, Marcel Apfelbaum wrote:
> >> Priority is used to make visible some subregions by obscuring
> >> the parent MemoryRegion addresses overlapping with the subregion.
> >>
> >> By allowing the priority to be negative the opposite can be done:
> >> Allow a subregion to be visible on all the addresses not covered
> >> by the parent MemoryRegion or other subregions.
> >>
> >> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> >
> > Seems harmless enough.
> >
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> No, the idea is good but this version is just broken.
> See the comments I made on the previous version which
> Marcel ignored :-(
>
> -- PMM
You are right, I missed the bugs.
Good catch, thanks.
next prev parent reply other threads:[~2013-09-09 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 11:21 [Qemu-devel] [PATCH RFC v3 0/2] pci: complete master abort protocol Marcel Apfelbaum
2013-09-09 11:21 ` [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's priority field to accept negative values Marcel Apfelbaum
2013-09-09 11:41 ` Michael S. Tsirkin
2013-09-09 11:45 ` Peter Maydell
2013-09-09 11:48 ` Michael S. Tsirkin [this message]
2013-09-09 11:49 ` Michael S. Tsirkin
2013-09-09 11:21 ` [Qemu-devel] [PATCH RFC v3 2/2] hw/pci: handle unassigned pci addresses Marcel Apfelbaum
2013-09-14 21:08 ` Michael S. Tsirkin
2013-09-15 6:35 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909114855.GF31476@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.