All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Hubert Kario <hkario@redhat.com>
Subject: Re: [PATCH] e2fsck: don't try to stop mmp if there is no superblock set up
Date: Mon, 9 Sep 2013 10:33:48 -0400	[thread overview]
Message-ID: <20130909143348.GC6059@thunk.org> (raw)
In-Reply-To: <520E5BF3.5090502@redhat.com>

On Fri, Aug 16, 2013 at 12:05:55PM -0500, Eric Sandeen wrote:
> Under some failure cases, we can get to fatal_error()
> without even having a superblock set up.  In that case,
> ext2fs_mmp_stop() will segfault when it tries to dereference
> fs->super.
> 
> Check for the existence of a superblock before we go
> down the ext2fs_mmp_stop() path to avoid this problem.
> 
> Reported-by: Hubert Kario <hkario@redhat.com>
> Addresses-Red-Hat-Bugzilla: #997972
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied.

					- Ted

      reply	other threads:[~2013-09-09 14:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 17:05 [PATCH] e2fsck: don't try to stop mmp if there is no superblock set up Eric Sandeen
2013-09-09 14:33 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909143348.GC6059@thunk.org \
    --to=tytso@mit.edu \
    --cc=hkario@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.