From: Mark Brown <broonie@kernel.org>
To: oku@iki.fi
Cc: Darren Etheridge <detheridge@ti.com>,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
Jyri Sarha <jsarha@ti.com>,
"Hebbar, Gururaja" <gururaja.hebbar@ti.com>,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH RFC 5/8] ASoC: davinci: Add support for AM33xx SoC Audio
Date: Mon, 9 Sep 2013 16:24:53 +0100 [thread overview]
Message-ID: <20130909152453.GL29403@sirena.org.uk> (raw)
In-Reply-To: <3080f759b7390ff36db367ef1faf8b9df0a8d64d.1378738436.git.jsarha@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]
On Mon, Sep 09, 2013 at 06:12:16PM +0300, oku@iki.fi wrote:
> obj-$(CONFIG_SND_DAVINCI_SOC) += snd-soc-davinci.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-davinci.o
> obj-$(CONFIG_SND_DAVINCI_SOC_I2S) += snd-soc-davinci-i2s.o
> obj-$(CONFIG_SND_DAVINCI_SOC_MCASP) += snd-soc-davinci-mcasp.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-davinci-mcasp.o
> obj-$(CONFIG_SND_DAVINCI_SOC_VCIF) += snd-soc-davinci-vcif.o
>
> # DAVINCI Machine Support
> snd-soc-evm-objs := davinci-evm.o
>
> obj-$(CONFIG_SND_DAVINCI_SOC_EVM) += snd-soc-evm.o
> +obj-$(CONFIG_SND_AM33XX_SOC) += snd-soc-evm.o
This appears to be trying to include a duplicate copy of some of the
existing code - that doesn't seem sensible? I'd expect to see
additional machines added with || and possibly also some help text
updates.
Even better would be to get the code to the point where it has no
machine dependencies at all.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-09-09 15:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:12 [PATCH RFC 0/8] Fix AM335x-evm analog audio support oku
2013-09-09 15:12 ` [PATCH RFC 1/8] ASoC: davinci-mcasp: Add pinctrl support oku
2013-09-09 15:19 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 2/8] ASoC: davinci-evm: Add device tree binding oku
2013-09-09 15:21 ` Mark Brown
2013-09-11 10:38 ` Jyri Sarha
2013-09-11 11:35 ` Mark Brown
2013-09-11 18:02 ` Jyri Sarha
2013-09-12 11:47 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 3/8] ASoC: davinci-mcasp: Get DMA related properties from DT oku
2013-09-09 15:25 ` Mark Brown
2013-09-11 11:48 ` Jyri Sarha
2013-09-12 11:08 ` Mark Brown
2013-09-12 11:34 ` Jyri Sarha
2013-09-12 11:56 ` Mark Brown
2013-09-12 12:10 ` Jyri Sarha
2013-09-13 10:34 ` Mark Brown
2013-09-13 10:50 ` Jyri Sarha
2013-09-13 17:53 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 4/8] ASoC: davinci-mcasp: Extract DMA channels directly " oku
2013-09-09 15:12 ` [PATCH RFC 5/8] ASoC: davinci: Add support for AM33xx SoC Audio oku
2013-09-09 15:24 ` Mark Brown [this message]
2013-09-09 15:12 ` [PATCH RFC 6/8] ARM/dts: am33xx: Add mcasp0 and mcasp1 device tree entries oku
2013-09-09 15:27 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 7/8] ARM/dts: am33xx: mcasp: Add new dma related properties oku
2013-09-09 15:12 ` [PATCH RFC 8/8] ARM/dts: am335x-evm: Add audio support for am335x-evm.dts oku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909152453.GL29403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=detheridge@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=oku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.