From: Al Viro <viro@ZenIV.linux.org.uk>
To: Waiman Long <waiman.long@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
"Norton, Scott J" <scott.norton@hp.com>,
George Spelvin <linux@horizon.com>,
John Stoffel <john@stoffel.org>
Subject: Re: [PATCH v4 1/1] dcache: Translating dentry into pathname without taking rename_lock
Date: Mon, 9 Sep 2013 19:07:21 +0100 [thread overview]
Message-ID: <20130909180720.GP13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <522E0B7A.2080401@hp.com>
On Mon, Sep 09, 2013 at 01:55:06PM -0400, Waiman Long wrote:
> >I'm not sure I like mixing rcu_read_lock() into that - d_path() and friends
> >can do that themselves just fine (it needs to be taken when seq is even),
> >and e.g. d_walk() doesn't need it at all. Other than that, I'm OK with
> >this variant.
>
> I think rcu_read_lock() is needed to make sure that the dentry won't
> be freed as we don't take d_lock now.
Sure, you do need that; the question is whether you need to take it in
the primitives you are introducing.
prev parent reply other threads:[~2013-09-09 18:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 16:18 [PATCH v4 0/1] dcache: Translating dentry into pathname without taking rename_lock Waiman Long
2013-09-09 16:18 ` [PATCH v4 1/1] " Waiman Long
2013-09-09 17:29 ` Al Viro
2013-09-09 17:45 ` Linus Torvalds
2013-09-09 17:56 ` Waiman Long
2013-09-09 18:06 ` Al Viro
2013-09-09 18:15 ` Linus Torvalds
2013-09-09 18:21 ` Al Viro
2013-09-09 18:36 ` Al Viro
2013-09-09 18:46 ` Al Viro
2013-09-09 18:46 ` Waiman Long
2013-09-09 19:10 ` Al Viro
2013-09-09 19:28 ` Al Viro
2013-09-09 22:57 ` Waiman Long
2013-09-10 0:40 ` George Spelvin
2013-09-10 0:57 ` Al Viro
2013-09-10 1:15 ` Ramkumar Ramachandra
2013-09-10 1:34 ` Linus Torvalds
2013-09-10 2:25 ` Al Viro
2013-09-10 2:33 ` Linus Torvalds
2013-09-10 3:12 ` Ramkumar Ramachandra
2013-09-10 8:24 ` George Spelvin
2013-09-10 3:57 ` Waiman Long
2013-09-09 17:55 ` Waiman Long
2013-09-09 18:07 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909180720.GP13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aswin@hp.com \
--cc=john@stoffel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=scott.norton@hp.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.