All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, ak@linux.intel.com, jolsa@redhat.com,
	namhyung.kim@lge.com, dsahern@gmail.com
Subject: Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support
Date: Mon, 9 Sep 2013 16:47:45 -0300	[thread overview]
Message-ID: <20130909192810.GA3825@infradead.org> (raw)
In-Reply-To: <1377079825-19057-3-git-send-email-eranian@google.com>

Em Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian escreveu:
> This patch adds support for the new PERF_RECORD_MMAP2
> record type exposed by the kernel. This is an extended
> PERF_RECORD_MMAP record. It adds for each file-backed
> mapping the device major, minor number and the inode
> number and generation. This triplet uniquely identifies
> the source of a file-backed mapping. It can be used to
> detect identical virtual mappings between processes, for
> instance.
> 
> The patch will prefer MMAP2 over MMAP.

I noticed the kernel part is in, and I'm going to use MMAP2 on that new
tool, so tried merging it, but:

I fixed it up wrt another patch that makes machine__find_thread receive pid/tid
but then 'perf test' complains about it, see below, trying to fix...

- Arnaldo


[root@sandy ~]# perf test -v 7
 7: Validate PERF_RECORD_* events & perf_sample fields     :
--- start ---
57503587100282 0 PERF_RECORD_SAMPLE
57503587104415 0 PERF_RECORD_SAMPLE
57503587106039 0 PERF_RECORD_SAMPLE
57503587107362 0 PERF_RECORD_SAMPLE
57503588263263 0 PERF_RECORD_COMM: sleep:1439
6180457940383 -1728826693 PERF_RECORD_MMAP2 1439/1439: [0x400000(0x7000) @ 0 00:1d 311442 9016]: /usr/bin/sleep
MMAP2 going backwards in time, prev=57503588263263, curr=6180457940383
MMAP2 with unexpected cpu, expected 0, got -1728826693
MMAP2 with unexpected pid, expected 1439, got 1701606191
MMAP2 with unexpected tid, expected 1439, got 28773
Unexpected perf_event->header.type 10!
6180457940383 -1728754371 PERF_RECORD_MMAP2 1439/1439: [0x3b7e000000(0x223000) @ 0 00:1d 309186 9016]: /usr/lib64/ld-2.16.so
MMAP2 with unexpected cpu, expected 0, got -1728754371
MMAP2 with unexpected pid, expected 1439, got 1932408369
MMAP2 with unexpected tid, expected 1439, got 111
Unexpected perf_event->header.type 10!
6180457940383 -1728699354 PERF_RECORD_MMAP2 1439/1439: [0x7fff2bdff000(0x1000) @ 0x7fff2bdff000 00:00 0 0]: [vdso]
MMAP2 with unexpected cpu, expected 0, got -1728699354
MMAP2 with unexpected pid, expected 1439, got 1935963739
MMAP2 with unexpected tid, expected 1439, got 23919
Unexpected perf_event->header.type 10!
6180457940383 -1728433298 PERF_RECORD_MMAP2 1439/1439: [0x3b7e400000(0x3b8000) @ 0 00:1d 309187 9016]: /usr/lib64/libc-2.16.so
MMAP2 with unexpected cpu, expected 0, got -1728433298
MMAP2 with unexpected pid, expected 1439, got 909192754
MMAP2 with unexpected tid, expected 1439, got 7303982
Unexpected perf_event->header.type 10!
57504589856948 0 PERF_RECORD_EXIT(1439:1439):(1439:1439)
PERF_RECORD_MMAP for sleep missing!
PERF_RECORD_MMAP for libc missing!
PERF_RECORD_MMAP for ld missing!
PERF_RECORD_MMAP for [vdso] missing!
---- end ----
Validate PERF_RECORD_* events & perf_sample fields: FAILED!
[root@sandy ~]#

  parent reply	other threads:[~2013-09-09 19:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 10:10 [PATCH v2 0/2] perf: add new PERF_RECORD_MMAP2 record type Stephane Eranian
2013-08-21 10:10 ` [PATCH v2 1/2] perf: add attr->mmap2 attribute to an event Stephane Eranian
2013-08-22 15:57   ` Arnaldo Carvalho de Melo
2013-09-02  7:41   ` [tip:perf/core] perf: Add " tip-bot for Stephane Eranian
2013-08-21 10:10 ` [PATCH v2 2/2] perf tools: add attr->mmap2 support Stephane Eranian
2013-08-22 10:51   ` Peter Zijlstra
2013-08-30 14:03     ` Stephane Eranian
2013-08-30 14:08       ` Peter Zijlstra
2013-08-30 14:15         ` Stephane Eranian
2013-08-30 17:32           ` Stephane Eranian
2013-08-31  6:00             ` Ingo Molnar
2013-09-09 19:47   ` Arnaldo Carvalho de Melo [this message]
2013-09-09 19:48     ` Arnaldo Carvalho de Melo
2013-09-10 13:00       ` Arnaldo Carvalho de Melo
2013-09-10 13:05         ` Stephane Eranian
2013-09-10 13:17           ` Arnaldo Carvalho de Melo
2013-09-10 19:58             ` Arnaldo Carvalho de Melo
2013-09-10 20:16               ` Arnaldo Carvalho de Melo
2013-09-11 14:42                 ` Stephane Eranian
2013-09-11 14:53                   ` Arnaldo Carvalho de Melo
2013-09-11 15:28                     ` Arnaldo Carvalho de Melo
2013-09-12  6:35                       ` Ingo Molnar
2013-09-10  9:17     ` Peter Zijlstra
2013-09-12 11:10   ` [tip:perf/urgent] perf tools: Add " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909192810.GA3825@infradead.org \
    --to=acme@ghostprotocols.net \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.