From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/6] Add clustername while creating new lockspace
Date: Mon, 9 Sep 2013 14:42:20 -0700 [thread overview]
Message-ID: <20130909214220.GD31381@wotan.suse.de> (raw)
In-Reply-To: <20130906032732.GA4159@shrek.lan>
On Thu, Sep 05, 2013 at 10:27:37PM -0500, Goldwyn Rodrigues wrote:
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 01b8516..60f3d8e 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2239,6 +2239,9 @@ static int ocfs2_initialize_super(struct super_block *sb,
> status = -EINVAL;
> goto bail;
> }
> + memcpy(osb->osb_cluster_name,
> + OCFS2_RAW_SB(di)->s_cluster_info.ci_cluster,
> + OCFS2_CLUSTER_NAME_LEN);
In the case of no extended cluster info (think o2cb stack) this field would
be NULL. Have you tested with o2cb to see what happens?
Btwm, since o2cb wouldn't ever use that info you could always put a dummy
value there if need be.
--Mark
--
Mark Fasheh
prev parent reply other threads:[~2013-09-09 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 3:27 [Ocfs2-devel] [PATCH 2/6] Add clustername while creating new lockspace Goldwyn Rodrigues
2013-09-09 21:42 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909214220.GD31381@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.