From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: check magic numbers in dir3 leaf verifier first
Date: Mon, 9 Sep 2013 17:51:37 -0500 [thread overview]
Message-ID: <20130909225137.GS1935@sgi.com> (raw)
In-Reply-To: <20130903000658.GJ12779@dastard>
On Tue, Sep 03, 2013 at 10:06:58AM +1000, Dave Chinner wrote:
> xfs: check magic numbers in dir3 leaf verifier first
>
> From: Dave Chinner <dchinner@redhat.com>
>
> Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
> validating the magic numbers in the buffer results in ASSERT
> failures due to mismatching magic numbers when a corruption occurs.
> Seeing as the verifier is supposed to catch the corruption and pass
> it back to the caller, having the verifier assert fail on error
> defeats the purpose of detecting the errors in the first place.
>
> Check the magic numbers direct from the buffer before decoding the
> header.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Cleaned up the spurious newline and applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-09 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:50 [PATCH] xfs: check magic numbers in dir3 leaf verifier first Dave Chinner
2013-09-03 0:06 ` [PATCH v2] " Dave Chinner
2013-09-03 7:33 ` Christoph Hellwig
2013-09-09 22:51 ` Ben Myers [this message]
2013-10-18 16:48 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909225137.GS1935@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.