All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode conversion
Date: Tue, 10 Sep 2013 12:38:24 +0300	[thread overview]
Message-ID: <20130910093824.GJ11428@intel.com> (raw)
In-Reply-To: <1378800168-32277-1-git-send-email-daniel.vetter@ffwll.ch>

On Tue, Sep 10, 2013 at 10:02:48AM +0200, Daniel Vetter wrote:
> Instead of just a flag bit for each of the positive/negative sync
> modes drm actually uses a separate flag for each ... This upsets the
> modeset checker since the adjusted mode filled out at modeset time
> doesn't match the one reconstructed at check time (since the
> ->get_config callback already gets this right).
> 
> Reported-by: Knut Petersen <Knut_Petersen@t-online.de>
> Cc: Knut Petersen <Knut_Petersen@t-online.de>
> References: http://www.gossamer-threads.com/lists/linux/kernel/1778688?do=post_view_threaded
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_sdvo.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 85037b9..5033c74 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -866,8 +866,12 @@ static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode * mode,
>  		mode->flags |= DRM_MODE_FLAG_INTERLACE;
>  	if (dtd->part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE)
>  		mode->flags |= DRM_MODE_FLAG_PHSYNC;
> +	else
> +		mode->flags |= DRM_MODE_FLAG_NHSYNC;
>  	if (dtd->part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE)
>  		mode->flags |= DRM_MODE_FLAG_PVSYNC;
> +	else
> +		mode->flags |= DRM_MODE_FLAG_NVSYNC;

Actually it seems we don't recreate the mode from scratch here, so we
should also clear the negative sync flags (and the interlace flag too) 
before we set them.

>  }
>  
>  static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo)
> -- 
> 1.8.4.rc3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

  parent reply	other threads:[~2013-09-10  9:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 21:58 [BUG kernel 3.11+] i915: pipe state doesn't match Knut Petersen
2013-09-07 16:54 ` [Intel-gfx] " Daniel Vetter
2013-09-09 10:07   ` Knut Petersen
2013-09-10  5:20   ` Knut Petersen
2013-09-10  8:02 ` [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode conversion Daniel Vetter
2013-09-10  8:24   ` [Intel-gfx] " Ville Syrjälä
2013-09-10 10:34     ` Daniel Vetter
2013-09-10  8:41   ` Knut Petersen
2013-09-10  9:28     ` Daniel Vetter
2013-09-10  9:44     ` [PATCH] drm/i915/tv: clear adjusted_mode.flags Daniel Vetter
2013-09-10  9:44       ` Daniel Vetter
2013-09-10 10:10       ` Knut Petersen
2013-09-24  5:52       ` Knut Petersen
2013-09-24  8:01         ` Daniel Vetter
2013-09-10  9:38   ` Ville Syrjälä [this message]
2013-09-10  9:42     ` [Intel-gfx] [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode conversion Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130910093824.GJ11428@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.