From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: rydberg@euromail.se, carl@ok-labs.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event
Date: Tue, 10 Sep 2013 17:12:36 -0700 [thread overview]
Message-ID: <20130911001235.GA5840@core.coreip.homeip.net> (raw)
In-Reply-To: <1378855973-11595-2-git-send-email-rmallon@gmail.com>
Hi Ryan,
On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote:
> Call input_inject_event rather than input_event in uinput_inject_event. This
> mirrors the behaviour of evdev_write. input_inject_event will ignore the
> injected event if the uinput input device has been grabbed for exclusive
> access by a handler other than uinput.
uinput is not an input handler but input driver and therefore should
continue using input_event().
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-09-11 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 23:32 [PATCH 1/2] uinput: Support injecting multiple events in one write() call Ryan Mallon
2013-09-10 23:32 ` [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event Ryan Mallon
2013-09-11 0:12 ` Dmitry Torokhov [this message]
2013-09-11 0:26 ` Ryan Mallon
2013-09-11 0:14 ` [PATCH 1/2] uinput: Support injecting multiple events in one write() call Dmitry Torokhov
2013-09-11 0:29 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911001235.GA5840@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=carl@ok-labs.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.