All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: lvs-devel@vger.kernel.org
Subject: Re: [PATCH net 3/4] ipvs: make the service replacement more robust
Date: Wed, 11 Sep 2013 12:58:58 +0900	[thread overview]
Message-ID: <20130911035858.GF23073@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1309102214530.1691@ja.ssi.bg>

On Tue, Sep 10, 2013 at 10:28:13PM +0300, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Wed, 28 Aug 2013, Julian Anastasov wrote:
> 
> > -	/* Some dest can be in grace period even before cleanup, we have to
> > -	 * defer ip_vs_trash_cleanup until ip_vs_dest_wait_readers is called.
> > -	 */
> > -	rcu_barrier();
> >  	ip_vs_trash_cleanup(net);
> >  	ip_vs_stop_estimator(net, &ipvs->tot_stats);
> >  	ip_vs_control_net_cleanup_sysctl(net);
> 
> 	Simon, I have to update this patch. rcu_barrier
> can not simply disappear because LBLC[R] use RCU callbacks
> and we have to wait them to put the final reference to dest
> before calling ip_vs_trash_cleanup(). It needs different
> solution, if possible without rcu_barrier. I'll send updated
> patchset in next days.

Thanks, noted.

  reply	other threads:[~2013-09-11  3:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 16:29 [PATCH net 0/4] IPVS fixes for corner cases Julian Anastasov
2013-08-28 16:29 ` [PATCH net 1/4] ipvs: do not use dest after ip_vs_dest_put in LBLC Julian Anastasov
2013-08-28 16:29 ` [PATCH net 2/4] ipvs: do not use dest after ip_vs_dest_put in LBLCR Julian Anastasov
2013-08-28 16:29 ` [PATCH net 3/4] ipvs: make the service replacement more robust Julian Anastasov
2013-09-10 19:28   ` Julian Anastasov
2013-09-11  3:58     ` Simon Horman [this message]
2013-08-28 16:29 ` [PATCH net 4/4] ipvs: stats should not depend on CPU 0 Julian Anastasov
2013-08-30  1:17   ` Simon Horman
2013-08-30  7:31     ` Julian Anastasov
2013-08-30  8:53       ` Simon Horman
2013-08-30  8:58         ` Simon Horman
2013-08-30  9:53           ` Julian Anastasov
2013-08-30  7:46   ` Hans Schillstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911035858.GF23073@verge.net.au \
    --to=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.