All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Jiri Olsa <jolsa@redhat.com>,
	Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 0/5] perf/urgent fixes
Date: Wed, 11 Sep 2013 07:55:03 +0200	[thread overview]
Message-ID: <20130911055503.GB15395@gmail.com> (raw)
In-Reply-To: <1378836722-31326-1-git-send-email-acme@infradead.org>


Hm, after this pull request, 'perf top' started misbehaving on older 
kernels:
             
             ┌─Error:────────────────────────────────────────────────────────────────────────────────────┐
             │The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (cycles).  │
             │/bin/dmesg may provide additional information.                                             │
             │No CONFIG_PERF_EVENTS=y kernel support configured?                                         │

But:

 $ cat /proc/sys/kernel/perf_event_paranoid 
 -1

The syscall really fails:

 16645 perf_event_open(0x1eb7f00, 0xffffffff, 0, 0xffffffff, 0) = -1 EINVAL (Invalid argument)
 16645 perf_event_open(0x1eb7f00, 0xffffffff, 0, 0xffffffff, 0) = -1 EINVAL (Invalid argument)
 16645 perf_event_open(0x1eb7f00, 0xffffffff, 0, 0xffffffff, 0) = -1 EINVAL (Invalid argument)

Caused by:

 575a9aab0f85 perf tools: Add attr->mmap2 support

We must not force mmap2 support to be present on the kernel side - new 
perf top should work on older kernels just as well.

So I've unpulled the tree for now.

Thanks,

	Ingo

  parent reply	other threads:[~2013-09-11  5:55 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 18:11 [GIT PULL 0/5] perf/urgent fixes Arnaldo Carvalho de Melo
2013-09-10 18:11 ` [PATCH 1/5] perf trace: Handle perf.data files with no tracepoints Arnaldo Carvalho de Melo
2013-09-10 18:11 ` [PATCH 2/5] perf evlist: Fix id pos in perf_evlist__open() Arnaldo Carvalho de Melo
2013-09-10 18:12 ` [PATCH 3/5] perf kvm: Fix sample_type manipulation Arnaldo Carvalho de Melo
2013-09-10 18:12 ` [PATCH 4/5] perf tools: Add attr->mmap2 support Arnaldo Carvalho de Melo
2013-09-10 18:12 ` [PATCH 5/5] perf: Fix up MMAP2 buffer space reservation Arnaldo Carvalho de Melo
2013-09-11  5:46 ` [GIT PULL 0/5] perf/urgent fixes Ingo Molnar
2013-09-11  5:55 ` Ingo Molnar [this message]
2013-09-11 14:08   ` Arnaldo Carvalho de Melo
2013-09-12  5:45     ` Ingo Molnar
2013-12-02  6:58       ` Brian Gitonga Marete
  -- strict thread matches above, loose matches on Subject: below --
2018-10-05 16:10 Arnaldo Carvalho de Melo
2018-10-05 16:14 ` Ingo Molnar
2018-07-30 20:50 Arnaldo Carvalho de Melo
2018-07-30 20:50 ` Arnaldo Carvalho de Melo
2018-07-31  5:51 ` Ingo Molnar
2018-07-31  5:51   ` Ingo Molnar
2018-05-14 12:23 Arnaldo Carvalho de Melo
2018-05-14 12:23 ` Arnaldo Carvalho de Melo
2018-05-14 12:23 ` Arnaldo Carvalho de Melo
2018-05-15  6:21 ` Ingo Molnar
2018-05-15  6:21   ` Ingo Molnar
2018-05-15  6:21   ` Ingo Molnar
2017-12-18 14:39 Arnaldo Carvalho de Melo
2017-12-18 14:39 ` Arnaldo Carvalho de Melo
2017-12-18 17:11 ` Ingo Molnar
2017-12-18 17:11   ` Ingo Molnar
2015-12-07 20:06 Arnaldo Carvalho de Melo
2015-12-08  5:09 ` Ingo Molnar
2015-11-13 20:57 Arnaldo Carvalho de Melo
2015-11-18  5:57 ` Ingo Molnar
2015-11-11 21:56 Arnaldo Carvalho de Melo
2015-11-12  6:38 ` Ingo Molnar
2015-09-17 18:54 Arnaldo Carvalho de Melo
2015-09-18  5:46 ` Ingo Molnar
2014-02-13 21:15 Arnaldo Carvalho de Melo
2014-02-22 16:23 ` Ingo Molnar
2013-11-19 20:41 Arnaldo Carvalho de Melo
2013-11-20 13:32 ` Ingo Molnar
2012-04-14 17:03 Arnaldo Carvalho de Melo
2012-04-15  6:04 ` Ingo Molnar
2012-04-05 23:28 Arnaldo Carvalho de Melo
2011-05-27 21:45 Arnaldo Carvalho de Melo
2011-05-28  9:41 ` Ingo Molnar
2011-05-29 14:12   ` Arnaldo Carvalho de Melo
2011-05-29 14:30     ` Ingo Molnar
2011-04-06 11:00 Arnaldo Carvalho de Melo
2011-04-06 11:10 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911055503.GB15395@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.