From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tushar Behera <tushar.behera@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Lidza Louina <lidza.louina@gmail.com>
Subject: Re: [PATCH] staging: dgnc: fix potential format string flaw
Date: Wed, 11 Sep 2013 12:31:18 +0300 [thread overview]
Message-ID: <20130911093118.GD25896@mwanda> (raw)
In-Reply-To: <CAGXu5jLm1RNp4mB2KfeRumTqeWgcAsZ4CpQQQGA67WukERefXQ@mail.gmail.com>
On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
> In the former case, format characters will get processed by the
> sprintf logic. In the latter, they are printed as-is. In this specific
> case, if there was a way to inject strings like "ohai %n" into the
> msgbuf string, the former would actually attempt to resolve the %n. In
> the simple case, this could lead to Oopses, and in the unlucky case,
> it could allow arbitrary memory writing and execution control.
>
> http://en.wikipedia.org/wiki/Uncontrolled_format_string
The kernel ignores %n so hopefully it can't actually write to memory.
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-11 9:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 4:41 [PATCH] staging: dgnc: fix potential format string flaw Kees Cook
2013-09-11 5:00 ` Joe Perches
2013-09-11 5:19 ` Kees Cook
2013-09-11 9:31 ` Dan Carpenter [this message]
2013-09-11 18:19 ` Kees Cook
2013-09-11 19:09 ` Joe Perches
2013-09-11 19:25 ` Kees Cook
2013-09-11 19:45 ` Joe Perches
2013-09-11 19:47 ` Kees Cook
2013-09-11 23:22 ` [RFC PATCH] vsnprintf: Remove use of %n and convert existing uses Joe Perches
2013-09-11 23:22 ` Joe Perches
2013-09-11 23:29 ` Kees Cook
2013-09-11 23:29 ` Kees Cook
2013-09-11 23:29 ` Kees Cook
2013-09-11 23:43 ` Joe Perches
2013-09-11 23:43 ` Joe Perches
2013-09-11 23:40 ` Tetsuo Handa
2013-09-11 23:40 ` Tetsuo Handa
2013-09-12 0:04 ` Joe Perches
2013-09-12 0:04 ` Joe Perches
2013-09-12 0:19 ` Al Viro
2013-09-12 0:19 ` Al Viro
2013-09-12 0:41 ` Joe Perches
2013-09-12 0:41 ` Joe Perches
2013-09-12 8:06 ` David Laight
2013-09-12 8:06 ` David Laight
2013-09-12 15:59 ` Joe Perches
2013-09-12 15:59 ` Joe Perches
2013-09-11 19:28 ` [PATCH] staging: dgnc: fix potential format string flaw Dan Carpenter
2013-09-11 19:22 ` Dan Carpenter
2013-09-11 19:26 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911093118.GD25896@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.