All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] sensors-detect : Fixing use of uninitialised value 'vendor_id' on ppc64
Date: Wed, 11 Sep 2013 12:07:53 +0000	[thread overview]
Message-ID: <20130911140753.4eabd461@endymion.delvare> (raw)
In-Reply-To: <1301926956.10694212.1378813074661.JavaMail.root@redhat.com>

Hi Jaromir,

On Tue, 10 Sep 2013 07:37:54 -0400 (EDT), Jaromir Capik wrote:
> There's no vendor_id entry in the /proc/cpuinfo file in case of PPC64
> systems and consequently the script returns 3 screens full of the
> following errors:
> 
> Use of uninitialized value in string eq at /usr/sbin/sensors-detect line 6444
> Use of uninitialized value in string eq at /usr/sbin/sensors-detect line 6459
> Use of uninitialized value in string eq at /usr/sbin/sensors-detect line 6473
> 
> The attached patch fixes that.
> 
> Please, merge.

Thanks for reporting. I don't think sensors-detect is terribly useful
on PPC64, but the fix is simple enough so can can take it. I have
committed a slightly different variant:
  http://www.lm-sensors.org/changeset/6196

Thanks for your contribution.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      reply	other threads:[~2013-09-11 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 11:37 [lm-sensors] [PATCH] sensors-detect : Fixing use of uninitialised value 'vendor_id' on ppc64 Jaromir Capik
2013-09-11 12:07 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130911140753.4eabd461@endymion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.