diff for duplicates of <20130911231455.GA23925@xanatos> diff --git a/a/1.txt b/N1/1.txt index 2f25412..a368e9e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ Xenia noticed that the xhci_readl functions can completely go away and be replaced by standard readl/writel operations. She's posted a patchset to do that: -http://marc.info/?l=linux-usb&m\x137874983529708&w=2 +http://marc.info/?l=linux-usb&m=137874983529708&w=2 I hate to do this to you, but her patch is a better improvement, so I'll be taking that series instead of your patch. I hope you can still find @@ -155,7 +155,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> addr = &ir_set->irq_pending; > >>- temp = xhci_readl(xhci, addr); > >>+ temp = xhci_readl(addr); -> >> if (temp = XHCI_INIT_VALUE) +> >> if (temp == XHCI_INIT_VALUE) > >> return; > >>@@ -187,17 +187,17 @@ void xhci_print_ir_set(struct xhci_hcd *xhci, int set_num) > >> (unsigned int)temp); @@ -270,7 +270,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> wIndex--; > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); -> >> if (temp = 0xffffffff) { +> >> if (temp == 0xffffffff) { > >> retval = -ENODEV; > >> break; > >>@@ -749,7 +749,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, @@ -279,7 +279,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> wIndex--; > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); -> >> if (temp = 0xffffffff) { +> >> if (temp == 0xffffffff) { > >> retval = -ENODEV; > >> break; > >>@@ -758,7 +758,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, @@ -297,7 +297,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> */ > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); -> >> if ((temp & PORT_PE) = 0 || (temp & PORT_RESET) +> >> if ((temp & PORT_PE) == 0 || (temp & PORT_RESET) > >> || (temp & PORT_PLS_MASK) >= XDEV_U3) { > >> xhci_warn(xhci, "USB core suspending device " > >>@@ -796,11 +796,11 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, @@ -311,7 +311,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); > >> /* Disable port */ -> >> if (link_state = USB_SS_PORT_LS_SS_DISABLED) { +> >> if (link_state == USB_SS_PORT_LS_SS_DISABLED) { > >>@@ -815,7 +815,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, > >> PORT_CEC; > >> xhci_writel(xhci, temp | PORT_PE, @@ -333,7 +333,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> spin_lock_irqsave(&xhci->lock, flags); > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); -> >> if (link_state = USB_SS_PORT_LS_U3) +> >> if (link_state == USB_SS_PORT_LS_U3) > >> bus_state->suspended_ports |= 1 << wIndex; > >> break; > >>@@ -872,7 +872,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, @@ -394,7 +394,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> wIndex--; > >>- temp = xhci_readl(xhci, port_array[wIndex]); > >>+ temp = xhci_readl(port_array[wIndex]); -> >> if (temp = 0xffffffff) { +> >> if (temp == 0xffffffff) { > >> retval = -ENODEV; > >> break; > >>@@ -939,7 +939,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, @@ -412,7 +412,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> for (i = 0; i < max_ports; i++) { > >>- temp = xhci_readl(xhci, port_array[i]); > >>+ temp = xhci_readl(port_array[i]); -> >> if (temp = 0xffffffff) { +> >> if (temp == 0xffffffff) { > >> retval = -ENODEV; > >> break; > >>@@ -1098,7 +1098,7 @@ int xhci_bus_suspend(struct usb_hcd *hcd) @@ -484,7 +484,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> addr = &xhci->cap_regs->hcc_params; > >>- offset = XHCI_HCC_EXT_CAPS(xhci_readl(xhci, addr)); > >>+ offset = XHCI_HCC_EXT_CAPS(xhci_readl(addr)); -> >> if (offset = 0) { +> >> if (offset == 0) { > >> xhci_err(xhci, "No Extended Capability registers, " > >> "unable to set up roothub.\n"); > >>@@ -2115,7 +2115,7 @@ static int xhci_setup_port_arrays(struct xhci_hcd *xhci, gfp_t flags) @@ -493,7 +493,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> u32 cap_id; > >>- cap_id = xhci_readl(xhci, tmp_addr); > >>+ cap_id = xhci_readl(tmp_addr); -> >> if (XHCI_EXT_CAPS_ID(cap_id) = XHCI_EXT_CAPS_PROTOCOL) +> >> if (XHCI_EXT_CAPS_ID(cap_id) == XHCI_EXT_CAPS_PROTOCOL) > >> cap_count++; > >> tmp_offset = XHCI_EXT_CAPS_NEXT(cap_id); > >>@@ -2129,7 +2129,7 @@ static int xhci_setup_port_arrays(struct xhci_hcd *xhci, gfp_t flags) @@ -501,7 +501,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> u32 cap_id; > >>- cap_id = xhci_readl(xhci, addr); > >>+ cap_id = xhci_readl(addr); -> >> if (XHCI_EXT_CAPS_ID(cap_id) = XHCI_EXT_CAPS_PROTOCOL) +> >> if (XHCI_EXT_CAPS_ID(cap_id) == XHCI_EXT_CAPS_PROTOCOL) > >> xhci_add_in_port(xhci, num_ports, addr, > >> (u8) XHCI_EXT_PORT_MAJOR(cap_id), > >>@@ -2234,7 +2234,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags) @@ -567,11 +567,11 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> port_id); > >>- temp = xhci_readl(xhci, port_array[faked_port_index]); > >>+ temp = xhci_readl(port_array[faked_port_index]); -> >> if (hcd->state = HC_STATE_SUSPENDED) { +> >> if (hcd->state == HC_STATE_SUSPENDED) { > >> xhci_dbg(xhci, "resume root hub\n"); > >> usb_hcd_resume_root_hub(hcd); > >>@@ -1684,7 +1684,7 @@ static void handle_port_status(struct xhci_hcd *xhci, -> >> if ((temp & PORT_PLC) && (temp & PORT_PLS_MASK) = XDEV_RESUME) { +> >> if ((temp & PORT_PLC) && (temp & PORT_PLS_MASK) == XDEV_RESUME) { > >> xhci_dbg(xhci, "port resume event for port %d\n", port_id); > >>- temp1 = xhci_readl(xhci, &xhci->op_regs->command); > >>+ temp1 = xhci_readl(&xhci->op_regs->command); @@ -583,7 +583,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> /* Check if the xHC generated the interrupt, or the irq is shared */ > >>- status = xhci_readl(xhci, &xhci->op_regs->status); > >>+ status = xhci_readl(&xhci->op_regs->status); -> >> if (status = 0xffffffff) +> >> if (status == 0xffffffff) > >> goto hw_died; > >>@@ -2783,7 +2783,7 @@ hw_died: > >> if (hcd->irq) { @@ -610,7 +610,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> do { > >>- result = xhci_readl(xhci, ptr); > >>+ result = xhci_readl(ptr); -> >> if (result = ~(u32)0) /* card removed */ +> >> if (result == ~(u32)0) /* card removed */ > >> return -ENODEV; > >> result &= mask; > >>@@ -82,11 +82,11 @@ void xhci_quiesce(struct xhci_hcd *xhci) @@ -638,7 +638,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> int ret, i; > >>- state = xhci_readl(xhci, &xhci->op_regs->status); > >>+ state = xhci_readl(&xhci->op_regs->status); -> >> if ((state & STS_HALT) = 0) { +> >> if ((state & STS_HALT) == 0) { > >> xhci_warn(xhci, "Host controller not halted, aborting reset.\n"); > >> return 0; > >> } @@ -652,7 +652,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> for (i = 0; i < xhci->num_usb3_ports; i++) { > >>- temp = xhci_readl(xhci, xhci->usb3_ports[i]); > >>+ temp = xhci_readl(xhci->usb3_ports[i]); -> >> if ((temp & PORT_PLS_MASK) = USB_SS_PORT_LS_COMP_MOD) { +> >> if ((temp & PORT_PLS_MASK) == USB_SS_PORT_LS_COMP_MOD) { > >> /* > >> * Compliance Mode Detected. Letting USB Core > >>@@ -611,19 +611,19 @@ int xhci_run(struct usb_hcd *hcd) @@ -786,7 +786,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> goto done; > >>- temp = xhci_readl(xhci, &xhci->op_regs->status); > >>+ temp = xhci_readl(&xhci->op_regs->status); -> >> if (temp = 0xffffffff || (xhci->xhc_state & XHCI_STATE_HALTED)) { +> >> if (temp == 0xffffffff || (xhci->xhc_state & XHCI_STATE_HALTED)) { > >> xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb, > >> "HW died, freeing TD."); > >>@@ -3593,7 +3593,7 @@ void xhci_free_dev(struct usb_hcd *hcd, struct usb_device *udev) @@ -794,7 +794,7 @@ On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrote: > >> /* Don't disable the slot if the host controller is dead. */ > >>- state = xhci_readl(xhci, &xhci->op_regs->status); > >>+ state = xhci_readl(&xhci->op_regs->status); -> >> if (state = 0xffffffff || (xhci->xhc_state & XHCI_STATE_DYING) || +> >> if (state == 0xffffffff || (xhci->xhc_state & XHCI_STATE_DYING) || > >> (xhci->xhc_state & XHCI_STATE_HALTED)) { > >> xhci_free_virt_device(xhci, udev->slot_id); > >>@@ -4102,12 +4102,12 @@ static int xhci_usb2_software_lpm_test(struct usb_hcd *hcd, diff --git a/a/content_digest b/N1/content_digest index e94c3c4..099d798 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\05226CF51.9050207@gmail.com\0" "From\0Sarah Sharp <sarah.a.sharp@linux.intel.com>\0" "Subject\0Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call\0" - "Date\0Wed, 11 Sep 2013 23:14:55 +0000\0" + "Date\0Wed, 11 Sep 2013 16:14:55 -0700\0" "To\0Kumar Gaurav <kumargauravgupta3@gmail.com>\0" "Cc\0gregkh@linuxfoundation.org" linux-usb@vger.kernel.org @@ -20,7 +20,7 @@ "be replaced by standard readl/writel operations. She's posted a\n" "patchset to do that:\n" "\n" - "http://marc.info/?l=linux-usb&m\0237874983529708&w=2\n" + "http://marc.info/?l=linux-usb&m=137874983529708&w=2\n" "\n" "I hate to do this to you, but her patch is a better improvement, so I'll\n" "be taking that series instead of your patch. I hope you can still find\n" @@ -170,7 +170,7 @@ "> >> \taddr = &ir_set->irq_pending;\n" "> >>-\ttemp = xhci_readl(xhci, addr);\n" "> >>+\ttemp = xhci_readl(addr);\n" - "> >> \tif (temp = XHCI_INIT_VALUE)\n" + "> >> \tif (temp == XHCI_INIT_VALUE)\n" "> >> \t\treturn;\n" "> >>@@ -187,17 +187,17 @@ void xhci_print_ir_set(struct xhci_hcd *xhci, int set_num)\n" "> >> \t\t\t(unsigned int)temp);\n" @@ -285,7 +285,7 @@ "> >> \t\twIndex--;\n" "> >>-\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\ttemp = xhci_readl(port_array[wIndex]);\n" - "> >> \t\tif (temp = 0xffffffff) {\n" + "> >> \t\tif (temp == 0xffffffff) {\n" "> >> \t\t\tretval = -ENODEV;\n" "> >> \t\t\tbreak;\n" "> >>@@ -749,7 +749,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" @@ -294,7 +294,7 @@ "> >> \t\twIndex--;\n" "> >>-\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\ttemp = xhci_readl(port_array[wIndex]);\n" - "> >> \t\tif (temp = 0xffffffff) {\n" + "> >> \t\tif (temp == 0xffffffff) {\n" "> >> \t\t\tretval = -ENODEV;\n" "> >> \t\t\tbreak;\n" "> >>@@ -758,7 +758,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" @@ -312,7 +312,7 @@ "> >> \t\t\t */\n" "> >>-\t\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\t\ttemp = xhci_readl(port_array[wIndex]);\n" - "> >> \t\t\tif ((temp & PORT_PE) = 0 || (temp & PORT_RESET)\n" + "> >> \t\t\tif ((temp & PORT_PE) == 0 || (temp & PORT_RESET)\n" "> >> \t\t\t\t|| (temp & PORT_PLS_MASK) >= XDEV_U3) {\n" "> >> \t\t\t\txhci_warn(xhci, \"USB core suspending device \"\n" "> >>@@ -796,11 +796,11 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" @@ -326,7 +326,7 @@ "> >>-\t\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\t\ttemp = xhci_readl(port_array[wIndex]);\n" "> >> \t\t\t/* Disable port */\n" - "> >> \t\t\tif (link_state = USB_SS_PORT_LS_SS_DISABLED) {\n" + "> >> \t\t\tif (link_state == USB_SS_PORT_LS_SS_DISABLED) {\n" "> >>@@ -815,7 +815,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" "> >> \t\t\t\t\tPORT_CEC;\n" "> >> \t\t\t\txhci_writel(xhci, temp | PORT_PE,\n" @@ -348,7 +348,7 @@ "> >> \t\t\tspin_lock_irqsave(&xhci->lock, flags);\n" "> >>-\t\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\t\ttemp = xhci_readl(port_array[wIndex]);\n" - "> >> \t\t\tif (link_state = USB_SS_PORT_LS_U3)\n" + "> >> \t\t\tif (link_state == USB_SS_PORT_LS_U3)\n" "> >> \t\t\t\tbus_state->suspended_ports |= 1 << wIndex;\n" "> >> \t\t\tbreak;\n" "> >>@@ -872,7 +872,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" @@ -409,7 +409,7 @@ "> >> \t\twIndex--;\n" "> >>-\t\ttemp = xhci_readl(xhci, port_array[wIndex]);\n" "> >>+\t\ttemp = xhci_readl(port_array[wIndex]);\n" - "> >> \t\tif (temp = 0xffffffff) {\n" + "> >> \t\tif (temp == 0xffffffff) {\n" "> >> \t\t\tretval = -ENODEV;\n" "> >> \t\t\tbreak;\n" "> >>@@ -939,7 +939,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,\n" @@ -427,7 +427,7 @@ "> >> \tfor (i = 0; i < max_ports; i++) {\n" "> >>-\t\ttemp = xhci_readl(xhci, port_array[i]);\n" "> >>+\t\ttemp = xhci_readl(port_array[i]);\n" - "> >> \t\tif (temp = 0xffffffff) {\n" + "> >> \t\tif (temp == 0xffffffff) {\n" "> >> \t\t\tretval = -ENODEV;\n" "> >> \t\t\tbreak;\n" "> >>@@ -1098,7 +1098,7 @@ int xhci_bus_suspend(struct usb_hcd *hcd)\n" @@ -499,7 +499,7 @@ "> >> \taddr = &xhci->cap_regs->hcc_params;\n" "> >>-\toffset = XHCI_HCC_EXT_CAPS(xhci_readl(xhci, addr));\n" "> >>+\toffset = XHCI_HCC_EXT_CAPS(xhci_readl(addr));\n" - "> >> \tif (offset = 0) {\n" + "> >> \tif (offset == 0) {\n" "> >> \t\txhci_err(xhci, \"No Extended Capability registers, \"\n" "> >> \t\t\t\t\"unable to set up roothub.\\n\");\n" "> >>@@ -2115,7 +2115,7 @@ static int xhci_setup_port_arrays(struct xhci_hcd *xhci, gfp_t flags)\n" @@ -508,7 +508,7 @@ "> >> \t\tu32 cap_id;\n" "> >>-\t\tcap_id = xhci_readl(xhci, tmp_addr);\n" "> >>+\t\tcap_id = xhci_readl(tmp_addr);\n" - "> >> \t\tif (XHCI_EXT_CAPS_ID(cap_id) = XHCI_EXT_CAPS_PROTOCOL)\n" + "> >> \t\tif (XHCI_EXT_CAPS_ID(cap_id) == XHCI_EXT_CAPS_PROTOCOL)\n" "> >> \t\t\tcap_count++;\n" "> >> \t\ttmp_offset = XHCI_EXT_CAPS_NEXT(cap_id);\n" "> >>@@ -2129,7 +2129,7 @@ static int xhci_setup_port_arrays(struct xhci_hcd *xhci, gfp_t flags)\n" @@ -516,7 +516,7 @@ "> >> \t\tu32 cap_id;\n" "> >>-\t\tcap_id = xhci_readl(xhci, addr);\n" "> >>+\t\tcap_id = xhci_readl(addr);\n" - "> >> \t\tif (XHCI_EXT_CAPS_ID(cap_id) = XHCI_EXT_CAPS_PROTOCOL)\n" + "> >> \t\tif (XHCI_EXT_CAPS_ID(cap_id) == XHCI_EXT_CAPS_PROTOCOL)\n" "> >> \t\t\txhci_add_in_port(xhci, num_ports, addr,\n" "> >> \t\t\t\t\t(u8) XHCI_EXT_PORT_MAJOR(cap_id),\n" "> >>@@ -2234,7 +2234,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)\n" @@ -582,11 +582,11 @@ "> >> \t\t\tport_id);\n" "> >>-\ttemp = xhci_readl(xhci, port_array[faked_port_index]);\n" "> >>+\ttemp = xhci_readl(port_array[faked_port_index]);\n" - "> >> \tif (hcd->state = HC_STATE_SUSPENDED) {\n" + "> >> \tif (hcd->state == HC_STATE_SUSPENDED) {\n" "> >> \t\txhci_dbg(xhci, \"resume root hub\\n\");\n" "> >> \t\tusb_hcd_resume_root_hub(hcd);\n" "> >>@@ -1684,7 +1684,7 @@ static void handle_port_status(struct xhci_hcd *xhci,\n" - "> >> \tif ((temp & PORT_PLC) && (temp & PORT_PLS_MASK) = XDEV_RESUME) {\n" + "> >> \tif ((temp & PORT_PLC) && (temp & PORT_PLS_MASK) == XDEV_RESUME) {\n" "> >> \t\txhci_dbg(xhci, \"port resume event for port %d\\n\", port_id);\n" "> >>-\t\ttemp1 = xhci_readl(xhci, &xhci->op_regs->command);\n" "> >>+\t\ttemp1 = xhci_readl(&xhci->op_regs->command);\n" @@ -598,7 +598,7 @@ "> >> \t/* Check if the xHC generated the interrupt, or the irq is shared */\n" "> >>-\tstatus = xhci_readl(xhci, &xhci->op_regs->status);\n" "> >>+\tstatus = xhci_readl(&xhci->op_regs->status);\n" - "> >> \tif (status = 0xffffffff)\n" + "> >> \tif (status == 0xffffffff)\n" "> >> \t\tgoto hw_died;\n" "> >>@@ -2783,7 +2783,7 @@ hw_died:\n" "> >> \tif (hcd->irq) {\n" @@ -625,7 +625,7 @@ "> >> \tdo {\n" "> >>-\t\tresult = xhci_readl(xhci, ptr);\n" "> >>+\t\tresult = xhci_readl(ptr);\n" - "> >> \t\tif (result = ~(u32)0)\t\t/* card removed */\n" + "> >> \t\tif (result == ~(u32)0)\t\t/* card removed */\n" "> >> \t\t\treturn -ENODEV;\n" "> >> \t\tresult &= mask;\n" "> >>@@ -82,11 +82,11 @@ void xhci_quiesce(struct xhci_hcd *xhci)\n" @@ -653,7 +653,7 @@ "> >> \tint ret, i;\n" "> >>-\tstate = xhci_readl(xhci, &xhci->op_regs->status);\n" "> >>+\tstate = xhci_readl(&xhci->op_regs->status);\n" - "> >> \tif ((state & STS_HALT) = 0) {\n" + "> >> \tif ((state & STS_HALT) == 0) {\n" "> >> \t\txhci_warn(xhci, \"Host controller not halted, aborting reset.\\n\");\n" "> >> \t\treturn 0;\n" "> >> \t}\n" @@ -667,7 +667,7 @@ "> >> \tfor (i = 0; i < xhci->num_usb3_ports; i++) {\n" "> >>-\t\ttemp = xhci_readl(xhci, xhci->usb3_ports[i]);\n" "> >>+\t\ttemp = xhci_readl(xhci->usb3_ports[i]);\n" - "> >> \t\tif ((temp & PORT_PLS_MASK) = USB_SS_PORT_LS_COMP_MOD) {\n" + "> >> \t\tif ((temp & PORT_PLS_MASK) == USB_SS_PORT_LS_COMP_MOD) {\n" "> >> \t\t\t/*\n" "> >> \t\t\t * Compliance Mode Detected. Letting USB Core\n" "> >>@@ -611,19 +611,19 @@ int xhci_run(struct usb_hcd *hcd)\n" @@ -801,7 +801,7 @@ "> >> \t\tgoto done;\n" "> >>-\ttemp = xhci_readl(xhci, &xhci->op_regs->status);\n" "> >>+\ttemp = xhci_readl(&xhci->op_regs->status);\n" - "> >> \tif (temp = 0xffffffff || (xhci->xhc_state & XHCI_STATE_HALTED)) {\n" + "> >> \tif (temp == 0xffffffff || (xhci->xhc_state & XHCI_STATE_HALTED)) {\n" "> >> \t\txhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,\n" "> >> \t\t\t\t\"HW died, freeing TD.\");\n" "> >>@@ -3593,7 +3593,7 @@ void xhci_free_dev(struct usb_hcd *hcd, struct usb_device *udev)\n" @@ -809,7 +809,7 @@ "> >> \t/* Don't disable the slot if the host controller is dead. */\n" "> >>-\tstate = xhci_readl(xhci, &xhci->op_regs->status);\n" "> >>+\tstate = xhci_readl(&xhci->op_regs->status);\n" - "> >> \tif (state = 0xffffffff || (xhci->xhc_state & XHCI_STATE_DYING) ||\n" + "> >> \tif (state == 0xffffffff || (xhci->xhc_state & XHCI_STATE_DYING) ||\n" "> >> \t\t\t(xhci->xhc_state & XHCI_STATE_HALTED)) {\n" "> >> \t\txhci_free_virt_device(xhci, udev->slot_id);\n" "> >>@@ -4102,12 +4102,12 @@ static int xhci_usb2_software_lpm_test(struct usb_hcd *hcd,\n" @@ -920,4 +920,4 @@ "> >>\n" > -395a55bd3810a4c8823869290fa68c7904578a5271c21fe18bd1f526ec97357d +432b0a095f9b1ef55d55a6385798421887714850bca71b1028b43253e2f71050
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.