From: Mark Tinguely <tinguely@sgi.com>
To: xfs@oss.sgi.com
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH] xfs: remove dead code from xlog_recover_inode_pass2
Date: Thu, 12 Sep 2013 09:01:23 -0500 [thread overview]
Message-ID: <20130912140127.489098296@sgi.com> (raw)
In-Reply-To: 20130912140122.873071199@sgi.com
[-- Attachment #1: xfs-remove-dead-code-xlog_recover_inode_pass2.patch --]
[-- Type: text/plain, Size: 821 bytes --]
Additional code in the error handler of xlog_recover_inode_pass2()
results in the following error:
static checker warning: "fs/xfs/xfs_log_recover.c:2999
xlog_recover_inode_pass2()
info: ignoring unreachable code."
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Tinguely <tinguely@sgi.com>
---
fs/xfs/xfs_log_recover.c | 3 ---
1 file changed, 3 deletions(-)
Index: b/fs/xfs/xfs_log_recover.c
===================================================================
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -2995,9 +2995,6 @@ error:
if (need_free)
kmem_free(in_f);
return XFS_ERROR(error);
-
- xfs_buf_relse(bp);
- goto error;
}
/*
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2013-09-12 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130912140122.873071199@sgi.com>
2013-09-12 14:01 ` Mark Tinguely [this message]
2013-09-12 14:50 ` [PATCH] xfs: remove dead code from xlog_recover_inode_pass2 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912140127.489098296@sgi.com \
--to=tinguely@sgi.com \
--cc=dan.carpenter@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.