All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mitch Harder <mitch.harder@sabayonlinux.org>
Cc: Minchan Kim <minchan@kernel.org>,
	Michael wang <wangyun@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jiang Liu <jiang.liu@huawei.com>, Nitin Gupta <ngupta@vflare.org>,
	Jerome Marchand <jmarchand@redhat.com>,
	devel@driverdev.osuosl.org
Subject: Re: BUG: scheduling while atomic 3.10.7 in ZRAM Swap
Date: Thu, 12 Sep 2013 09:42:58 -0700	[thread overview]
Message-ID: <20130912164258.GC11614@kroah.com> (raw)
In-Reply-To: <CAKcLGm_NrnK8yCfsBWoT0mBC+kyG3kgVt61ORfazbWaRBDya7A@mail.gmail.com>

On Wed, Sep 11, 2013 at 06:08:08PM -0500, Mitch Harder wrote:
> On Tue, Aug 20, 2013 at 9:51 AM, Mitch Harder
> <mitch.harder@sabayonlinux.org> wrote:
> > On Sun, Aug 18, 2013 at 11:44 PM, Minchan Kim <minchan@kernel.org> wrote:
> >> Hello,
> >>
> >> On Mon, Aug 19, 2013 at 12:13:02PM +0800, Michael wang wrote:
> >>> Hi, Mitch
> >>>
> >>> On 08/17/2013 10:01 PM, Mitch Harder wrote:
> >>> > I'm encountering a BUG while using a ZRAM Swap device.
> >>> >
> >>> > The call trace seems to involve the changes recently added to 3.10.6
> >>> > by the patch:
> >>> > zram: use zram->lock to protect zram_free_page() in swap free notify path
> >>> >
> >>> > The hardware is a x86 single CPU AMD Athlon XP system with 1GB RAM.
> >>> >
> >>> > I'm implementing a 352MB ZRAM swap device, and also have 1GB swap
> >>> > space on the hard disk.
> >>>
> >>> IMHO, it was caused by that swap_entry_free() was invoked with page
> >>> spin-locked, thus zram_slot_free_notify() should not use rw-lock which
> >>> may goto sleep.
> >>>
> >>> CC folks related.
> >>
> >> Thanks for Ccing me, Michael,
> >>
> >> Mitch, It's known problem and it should be fixed by [1] in recent linux-next.
> >>
> >> [1] a0c516cbfc, zram: don't grab mutex in zram_slot_free_noity
> >>
> >> Thanks for the report!
> >>
> >
> > Thanks.
> >
> > If I apply the zram patches from linux-next, the problem seems to be resolved.
> 
> Is it planned to send the patch: "zram: don't grab mutex in
> zram_slot_free_noity"  to stable?
> 
> I noticed that 3.10.11 still doesn't have this patch.

That's because it isn't in a released kernel from Linus yet.  Wait for
3.12-rc1 to come out, then I will queue it up.

thanks,

greg k-h

      reply	other threads:[~2013-09-12 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 14:01 BUG: scheduling while atomic 3.10.7 in ZRAM Swap Mitch Harder
2013-08-19  4:13 ` Michael wang
2013-08-19  4:44   ` Minchan Kim
2013-08-20 14:51     ` Mitch Harder
2013-09-11 23:08       ` Mitch Harder
2013-09-12 16:42         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912164258.GC11614@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jiang.liu@huawei.com \
    --cc=jmarchand@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=mitch.harder@sabayonlinux.org \
    --cc=ngupta@vflare.org \
    --cc=wangyun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.