From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: smatch@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Smatch messages that are not understood
Date: Fri, 13 Sep 2013 01:43:12 +0300 [thread overview]
Message-ID: <20130912224312.GJ25896@mwanda> (raw)
In-Reply-To: <52324046.5060709@lwfinger.net>
On Thu, Sep 12, 2013 at 05:29:26PM -0500, Larry Finger wrote:
> Hi,
>
> I am in the process of fixing smatch warnings and errors in the
> rtlwifi family of drivers. Most are straight forward; however, some
> routines show info messages originating from an inline routine in
> the header files as follows:
>
> CHECK drivers/net/wireless/rtlwifi/rtl8192ce/dm.c
> include/linux/etherdevice.h:278 ether_addr_equal_64bits() info:
> ignoring unreachable code.
> include/linux/etherdevice.h:278 ether_addr_equal_64bits() info:
> ignoring unreachable code.
>
> The source code is a current pull of the mainline git tree. I'm not
> sure if this is a subtle case of unreachable code that I do not see,
> or if it is a smatch bug.
include/linux/etherdevice.h
275 if (sizeof(fold) == 8)
276 return zap_last_2bytes(fold) == 0;
277
278 fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^
279 (*(unsigned long *)(addr2 + 4)));
It's hitting the (sizeof(fold) == 8) and returning.
regards,
dan carpenter
prev parent reply other threads:[~2013-09-12 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 22:29 Smatch messages that are not understood Larry Finger
2013-09-12 22:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912224312.GJ25896@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.