From: ZHAO Gang <gamerh2o@gmail.com>
To: gamerh2o@gmail.com
Cc: Or Gerlitz <or.gerlitz@gmail.com>,
Prarit Bhargava <prarit@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH] net, mellanox mlx4 Fix compile warnings
Date: Sun, 15 Sep 2013 14:22:23 +0800 [thread overview]
Message-ID: <20130915062125.GA20185@will> (raw)
In-Reply-To: <20130915091400.49f90bc4@jpm-OptiPlex-GX620>
hell what!
On Sun, Sep 15, 2013 at 09:14:00AM +0300, Jack Morgenstein wrote:
> On Sat, 14 Sep 2013 22:10:19 +0300
> Or Gerlitz <or.gerlitz@gmail.com> wrote:
>
> > > + struct res_cq *uninitialized_var(cq);
> > >
> > > err = cq_res_start_move_to(dev, slave, cqn,
> > > RES_CQ_ALLOCATED, &cq);
>
> I have no objection. However, I don't know if the compiler is being too
> clever here or too stupid. The cq variable is initialized in
> cq_res_start_move_to(), but the compiler is ignoring this -- or maybe
> it is simply not assuming that cq will in fact be
> initialized by the called procedure?
>
> In any event, this change cannot hurt.
>
> -Jack
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-15 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 12:30 [PATCH] net, mellanox mlx4 Fix compile warnings Prarit Bhargava
2013-09-14 19:10 ` Or Gerlitz
2013-09-15 6:14 ` Jack Morgenstein
2013-09-15 6:22 ` ZHAO Gang [this message]
2013-09-15 6:27 ` ZHAO Gang
2013-09-16 8:59 ` David Laight
2013-09-16 12:14 ` Prarit Bhargava
2013-09-16 13:52 ` Jack Morgenstein
2013-09-17 1:25 ` David Miller
2013-09-17 19:13 ` [PATCH 2/2] " Prarit Bhargava
2013-09-17 19:25 ` Or Gerlitz
2013-09-17 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130915062125.GA20185@will \
--to=gamerh2o@gmail.com \
--cc=amirv@mellanox.com \
--cc=dledford@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.