From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Hurley <peter@hurleysoftware.com>
Cc: codonell <codonell@redhat.com>, Eduard Benes <ebenes@redhat.com>,
Karel Srot <ksrot@redhat.com>, Matt Newsome <mnewsome@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] tty: disassociate_ctty() sends the extra SIGCONT
Date: Sun, 15 Sep 2013 17:50:06 +0200 [thread overview]
Message-ID: <20130915155006.GA11913@redhat.com> (raw)
Hello.
I know nothing about tty's, I have no idea why disassociate_ctty()
checked on_exit before kill_pgrp(SIGCONT). And why this depends on
tty/old_pgrp/TTY_DRIVER_TYPE_PTY.
But this was changed in v3.10, probably by f91e2590 "tty: Signal
foreground group processes in hangup", and this breaks LSB tests
which do not expect the "wrong" SIGCONT.
The patch cc's stable, but it needs the ack or nack from someone
who these HUP/CONT rules.
IOW, I won't argue if the user-visible (and undocumented) change
added by f91e2590 is actually fine, in this case LSB should be
fixed.
Oleg.
next reply other threads:[~2013-09-15 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 15:50 Oleg Nesterov [this message]
2013-09-15 15:50 ` [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT Oleg Nesterov
2013-09-16 22:16 ` Peter Hurley
2013-09-17 19:41 ` Carlos O'Donell
2013-09-17 20:30 ` Peter Hurley
2013-09-17 20:39 ` Peter Hurley
2013-09-21 18:34 ` Oleg Nesterov
2013-09-21 20:25 ` Peter Hurley
2013-09-22 20:03 ` Oleg Nesterov
2013-09-24 18:18 ` Peter Hurley
2013-09-25 16:21 ` v3.10 breaks T.tcflush (Was: tty: disassociate_ctty() sends the extra SIGCONT) Oleg Nesterov
2013-09-25 17:56 ` Oleg Nesterov
2013-09-26 0:06 ` Peter Hurley
2013-09-26 0:13 ` [PATCH] tty: Fix SIGTTOU not sent with tcflush() Peter Hurley
2013-09-26 0:24 ` Greg Kroah-Hartman
2013-09-26 16:36 ` Oleg Nesterov
2013-09-26 19:10 ` Oleg Nesterov
2013-09-26 21:18 ` Peter Hurley
2013-09-27 5:19 ` Karel Srot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130915155006.GA11913@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=codonell@redhat.com \
--cc=ebenes@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=ksrot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnewsome@redhat.com \
--cc=peter@hurleysoftware.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.