All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcel Apfelbaum <marcel.a@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] docs/memory.txt: Clarify and expand priority/overlap documentation
Date: Sun, 15 Sep 2013 20:36:16 +0300	[thread overview]
Message-ID: <20130915173615.GA4971@redhat.com> (raw)
In-Reply-To: <CAFEAcA9FgUAZ2cqMX_MQmpg8FUVCWj+HJ+c0vx2VSwhL-nhhiA@mail.gmail.com>

On Sun, Sep 15, 2013 at 06:29:51PM +0100, Peter Maydell wrote:
> On 15 September 2013 18:07, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, Sep 15, 2013 at 05:55:54PM +0100, Peter Maydell wrote:
> >> On 15 September 2013 16:24, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > On Sun, Sep 15, 2013 at 03:51:53PM +0100, Peter Maydell wrote:
> >> >>  The memory core uses the following rules to select a memory region when the
> >> >> @@ -93,8 +136,11 @@ guest accesses an address:
> >> >>    - if the subregion is a leaf (RAM or MMIO), the search terminates
> >> >
> >> > Maybe add
> >> > "And the leaf is selected"
> >>
> >> Not sure what you mean by "selected" here.
> >
> > Well search terminates but what is the result?
> > It says "to select a memory region"
> > so for the result I said "is selected".
> 
> Oh, I see. I thought you were suggesting "if the subregion is a leaf
> and the leaf is selected, the search terminates"...
> 
> My suggested text below uses the phrasing "the search terminates
> with X", so perhaps "the search terminates with this leaf region" ?
> Better, make both of them be "the search terminates, returning X".
> 
> -- PMM

Sounds good.

      reply	other threads:[~2013-09-15 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15 14:51 [Qemu-devel] [PATCH] docs/memory.txt: Clarify and expand priority/overlap documentation Peter Maydell
2013-09-15 15:24 ` Michael S. Tsirkin
2013-09-15 16:55   ` Peter Maydell
2013-09-15 17:07     ` Michael S. Tsirkin
2013-09-15 17:29       ` Peter Maydell
2013-09-15 17:36         ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130915173615.GA4971@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=marcel.a@redhat.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.