From: Arnd Bergmann <arnd@arndb.de>
To: Domenico Andreoli <domenico.andreoli@linux.com>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 4/4] ARM: bcm4760: Add restart hook
Date: Sun, 15 Sep 2013 20:09:26 +0200 [thread overview]
Message-ID: <201309152009.26462.arnd@arndb.de> (raw)
In-Reply-To: <20130914152124.317379835@gmail.com>
On Saturday 14 September 2013, Domenico Andreoli wrote:
> +
> +static int __init bcm4760_wdt_init(void)
> +{
> + struct device_node *node;
> +
> + node = of_find_matching_node(NULL, bcm4760_pm_wdt_match);
> + if (!node) {
> + pr_info("No bcm4760 watchdog node\n");
> + return -1;
> + }
> +
> + wdt_regs = of_iomap(node, 0);
> + of_node_put(node);
Since this is now in the drivers directory and initialized at regular
module_init level, I'd ask you to register it as a proper platform_driver
and move the initialization into the probe() callback. You also need to
put Wim as the watchdog subsystem maintainer on Cc (I did in this reply)
and ask him to merge the driver.
I assume that Wim will ask you to add a watchdog_register_device() call
and a set of watchdog_ops to make this a functional driver. From the
platform perspective, I don't care, but it is certainly a logical step.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/4] ARM: bcm4760: Add restart hook
Date: Sun, 15 Sep 2013 20:09:26 +0200 [thread overview]
Message-ID: <201309152009.26462.arnd@arndb.de> (raw)
In-Reply-To: <20130914152124.317379835@gmail.com>
On Saturday 14 September 2013, Domenico Andreoli wrote:
> +
> +static int __init bcm4760_wdt_init(void)
> +{
> + struct device_node *node;
> +
> + node = of_find_matching_node(NULL, bcm4760_pm_wdt_match);
> + if (!node) {
> + pr_info("No bcm4760 watchdog node\n");
> + return -1;
> + }
> +
> + wdt_regs = of_iomap(node, 0);
> + of_node_put(node);
Since this is now in the drivers directory and initialized at regular
module_init level, I'd ask you to register it as a proper platform_driver
and move the initialization into the probe() callback. You also need to
put Wim as the watchdog subsystem maintainer on Cc (I did in this reply)
and ask him to merge the driver.
I assume that Wim will ask you to add a watchdog_register_device() call
and a set of watchdog_ops to make this a functional driver. From the
platform perspective, I don't care, but it is certainly a logical step.
Arnd
next prev parent reply other threads:[~2013-09-15 18:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 15:20 [PATCH v4 0/4] ARM: Broadcom BCM4760 support Domenico Andreoli
2013-09-14 15:20 ` [PATCH v4 1/4] ARM: bcm4760: Add platform infrastructure Domenico Andreoli
2013-09-15 18:03 ` Arnd Bergmann
2013-09-14 15:20 ` [PATCH v4 2/4] ARM: bcm4760: Add system timer Domenico Andreoli
2013-09-14 15:20 ` [PATCH v4 3/4] ARM: bcm4760: Add ripple counter Domenico Andreoli
2013-09-14 15:20 ` [PATCH v4 4/4] ARM: bcm4760: Add restart hook Domenico Andreoli
2013-09-15 18:09 ` Arnd Bergmann [this message]
2013-09-15 18:09 ` Arnd Bergmann
2013-09-15 18:52 ` Domenico Andreoli
2013-09-15 18:52 ` Domenico Andreoli
2013-09-15 20:10 ` Arnd Bergmann
2013-09-15 20:10 ` Arnd Bergmann
2013-09-16 7:18 ` Domenico Andreoli
2013-09-16 7:18 ` Domenico Andreoli
2013-09-16 8:45 ` Arnd Bergmann
2013-09-16 8:45 ` Arnd Bergmann
2013-09-16 12:00 ` Wim Van Sebroeck
2013-09-16 20:01 ` Arnd Bergmann
2013-09-16 20:01 ` Arnd Bergmann
2013-09-30 14:02 ` Domenico Andreoli
2013-09-30 14:02 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309152009.26462.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=domenico.andreoli@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.