From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Why does test_bit() take a volatile addr?
Date: Mon, 16 Sep 2013 10:26:03 +0300 [thread overview]
Message-ID: <20130916072603.GA11007@redhat.com> (raw)
In-Reply-To: <20130916165344.144f0d0f1b58111f1c8c87cc@canb.auug.org.au>
On Mon, Sep 16, 2013 at 04:53:44PM +1000, Stephen Rothwell wrote:
> Hi Rusty,
>
> On Mon, 16 Sep 2013 13:38:35 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
> >
> > Predates git, does anyone remember the rationale?
> >
> > ie:
> > int test_bit(int nr, const volatile unsigned long *addr)
>
> Because we sometimes pass volatile pointers to it and gcc will complain
> if you pass a volatile to a non volatile (I think).
Where are these? I did git grep -W test_bit and looked for volatile,
couldn't find anything.
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
next prev parent reply other threads:[~2013-09-16 7:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 4:08 Why does test_bit() take a volatile addr? Rusty Russell
2013-09-16 6:53 ` Stephen Rothwell
2013-09-16 7:26 ` Michael S. Tsirkin [this message]
2013-09-16 8:02 ` Stephen Rothwell
2013-09-16 8:47 ` Michael S. Tsirkin
2013-09-16 8:20 ` Geert Uytterhoeven
2013-09-16 8:37 ` Michael S. Tsirkin
2013-09-16 8:40 ` Oliver Neukum
2013-09-16 8:44 ` Michael S. Tsirkin
2013-09-16 8:49 ` Oliver Neukum
2013-09-16 11:59 ` Linus Torvalds
2013-09-22 21:37 ` Rob Landley
2013-09-23 1:13 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916072603.GA11007@redhat.com \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.