From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@kernel.org, acme@infradead.org,
linux-kernel@vger.kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/6] perf, core: Add generic transaction flags v4
Date: Mon, 16 Sep 2013 12:58:02 +0200 [thread overview]
Message-ID: <20130916105802.GD29018@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1379095716-4705-2-git-send-email-andi@firstfloor.org>
On Fri, Sep 13, 2013 at 11:08:31AM -0700, Andi Kleen wrote:
> /*
> + * Values for the transaction event qualifier, mostly for abort events.
> + * Multiple bits can be set.
> + */
> +enum {
> + PERF_SAMPLE_TXN_ELISION = (1 << 0), /* From elision */
> + PERF_SAMPLE_TXN_TRANSACTION = (1 << 1), /* From transaction */
> + PERF_SAMPLE_TXN_SYNC = (1 << 2), /* Instruction is related */
> + PERF_SAMPLE_TXN_ASYNC = (1 << 3), /* Instruction not related */
> + PERF_SAMPLE_TXN_RETRY = (1 << 4), /* Retry possible */
> + PERF_SAMPLE_TXN_CONFLICT = (1 << 5), /* Conflict abort */
> + PERF_SAMPLE_TXN_CAPACITY_WRITE = (1 << 6), /* Capacity write abort */
> + PERF_SAMPLE_TXN_CAPACITY_READ = (1 << 7), /* Capacity read abort */
> +
> + PERF_SAMPLE_TXN_MAX = (1 << 8), /* non-ABI */
> +
> + /* bits 24..31 are reserved for the abort code */
> +
> + PERF_SAMPLE_TXN_ABORT_MASK = 0xff000000,
> + PERF_SAMPLE_TXN_ABORT_SHIFT = 24,
> +};
Why bits 24..31 ? Why not push the abort code into the upper 32 bits?
next prev parent reply other threads:[~2013-09-16 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 18:08 perf, x86: Add last TSX PMU code for Haswell Andi Kleen
2013-09-13 18:08 ` [PATCH 1/6] perf, core: Add generic transaction flags v4 Andi Kleen
2013-09-16 10:58 ` Peter Zijlstra [this message]
2013-09-16 11:04 ` Peter Zijlstra
2013-09-13 18:08 ` [PATCH 2/6] perf, x86: Add Haswell specific transaction flag reporting v4 Andi Kleen
2013-09-16 11:08 ` Peter Zijlstra
2013-09-16 11:21 ` Peter Zijlstra
2013-09-13 18:08 ` [PATCH 3/6] perf, tools: Support sorting by in_tx, abort branch flags v3 Andi Kleen
2013-09-13 18:08 ` [PATCH 4/6] perf, tools: Add abort_tx,no_tx,in_tx branch filter options to perf record -j v3 Andi Kleen
2013-09-13 18:08 ` [PATCH 5/6] perf, tools: Add support for record transaction flags v4 Andi Kleen
2013-09-13 18:08 ` [PATCH 6/6] perf, x86: Suppress duplicated abort LBR records Andi Kleen
2013-09-16 11:28 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916105802.GD29018@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.