From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] worth correcting spelling of "redundand"?
Date: Mon, 16 Sep 2013 13:03:33 +0200 [thread overview]
Message-ID: <20130916130333.76d7991a@lilith> (raw)
In-Reply-To: <alpine.DEB.2.02.1309160426120.11845@oneiric>
Hi Robert,
On Mon, 16 Sep 2013 04:30:09 -0400 (EDT), "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:
>
> again, my pedantry getting the best of me but it makes me cringe
> whenever i run across the spelling "redundand" (tree-wide search):
>
> common/env_ubi.c:#ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
> [...]
>
> this obviously isn't a cosmetic change as it's used in numerous
> #defines, but if it's done all at once, it should be safe. i can
> submit a patch unless people feel it's simply too disruptive.
As a general rule, you don't need to ask before submitting a patch
unless you're really doing intrusive and potentially disruptive work
and want some feedback without risking getting bad code mainlined, in
which case... you'd still submit a patch, only tagged RFC. :)
IOW: just submit the patch; after all, the worst possible outcome is
only a NAK if you missed something important.
Here, just submit a patch with a summary line / subject like "fix
CONFIG_SYS_REDUNDAND_ENVIRONMENT typo".
> rday
Amicalement,
--
Albert.
prev parent reply other threads:[~2013-09-16 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 8:30 [U-Boot] worth correcting spelling of "redundand"? Robert P. J. Day
2013-09-16 11:03 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916130333.76d7991a@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.