From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 5/6] tune2fs: Zero inode table when removing checksums
Date: Mon, 16 Sep 2013 09:53:05 -0400 [thread overview]
Message-ID: <20130916135305.GD4457@thunk.org> (raw)
In-Reply-To: <20130829004417.3190.38773.stgit@blackbox.djwong.org>
On Wed, Aug 28, 2013 at 05:44:17PM -0700, Darrick J. Wong wrote:
> When disabling group checksums, we have to initialize the inode table. Right
> now tune2fs doesn't do this; it merely punts to e2fsck to clean up the mess.
> Unfortunately, if the "uninitialized" inode table contains things that look
> like inodes (i_link_count > 0, specifically), the e2fsck tries to recover these
> inodes. This leads to it misinterpreting i_blocks as a block map, at which
> point it needlessly resurrects phantom inodes and crosslinked file repairs. As
> part of initializing the block bitmaps, we must also mark block group metadata
> blocks in use.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2013-09-16 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 0:43 [RFC PATCH v1 0/6] e2fsprogs 8/2013 patchbomb Darrick J. Wong
2013-08-29 0:43 ` [PATCH 1/6] libext2fs: ext2fs_dup_handle should not alias MMP buffers Darrick J. Wong
2013-09-09 14:39 ` Theodore Ts'o
2013-08-29 0:43 ` [PATCH 2/6] resize2fs: Use blk64_t and location getters for free_gdp_blocks() Darrick J. Wong
2013-09-09 14:41 ` Theodore Ts'o
2013-08-29 0:44 ` [PATCH 3/6] e2fsck: Fix incorrect bbitmap checksum failure caused by integer overflow Darrick J. Wong
2013-09-16 13:42 ` Theodore Ts'o
2013-08-29 0:44 ` [PATCH 4/6] e2fsprogs: Add (optional) sparse checking to the build Darrick J. Wong
2013-08-29 0:44 ` [PATCH 5/6] tune2fs: Zero inode table when removing checksums Darrick J. Wong
2013-09-16 13:53 ` Theodore Ts'o [this message]
2013-08-29 0:44 ` [PATCH 6/6] resize2fs: Convert fs to and from 64bit mode Darrick J. Wong
2013-09-09 17:29 ` Darrick J. Wong
2013-09-09 17:47 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916135305.GD4457@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.