All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: "Jürgen Beisert" <jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
	Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Otavio Salvador
	<otavio.salvador-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection
Date: Mon, 16 Sep 2013 16:23:48 +0200	[thread overview]
Message-ID: <201309161623.48247.marex@denx.de> (raw)
In-Reply-To: <201309161010.22151.jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Dear Jürgen Beisert,

> Hi Jonathan,
> 
> On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> > > For battery driven systems it is a very bad idea to collect the
> > > touchscreen data within a kernel busy loop.
> > > 
> > > This change uses the features of the hardware to delay and accumulate
> > > samples in hardware to avoid a high interrupt and CPU load.
> > > 
> > > Note: this is only tested on an i.MX23 SoC yet.
> > > 
> > > Signed-off-by: Juergen Beisert <jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> > > CC: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org
> > > CC: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > > CC: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > CC: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
> > 
> > While this driver is placed in IIO within staging at the moment, these
> > changes are definitely input related.  Hence I have cc'd Dmitry and the
> > input list.
> > 
> > I am personaly a little uncomfortable that we have such a complex bit of
> > input code sat within an IIO driver but such is life.
> 
> Maybe an MFD for this ADC unit would be a better way to go? Currently I
> have a different problem with this driver, because the ADC unit monitors
> the battery as well. And the charging driver from the power subsystem
> needs these values to charge the battery in a correct manner.

Are you planning to post the power block patches too ?

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: "Jürgen Beisert" <jbe@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	fabio.estevam@freescale.com, jic23@cam.ac.uk,
	Torokhov <dmitry.torokhov@gmail.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Otavio Salvador <otavio.salvador@gmail.com>
Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection
Date: Mon, 16 Sep 2013 16:23:48 +0200	[thread overview]
Message-ID: <201309161623.48247.marex@denx.de> (raw)
In-Reply-To: <201309161010.22151.jbe@pengutronix.de>

Dear Jürgen Beisert,

> Hi Jonathan,
> 
> On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> > > For battery driven systems it is a very bad idea to collect the
> > > touchscreen data within a kernel busy loop.
> > > 
> > > This change uses the features of the hardware to delay and accumulate
> > > samples in hardware to avoid a high interrupt and CPU load.
> > > 
> > > Note: this is only tested on an i.MX23 SoC yet.
> > > 
> > > Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> > > CC: linux-arm-kernel@lists.infradead.org
> > > CC: devel@driverdev.osuosl.org
> > > CC: Marek Vasut <marex@denx.de>
> > > CC: Fabio Estevam <fabio.estevam@freescale.com>
> > > CC: Jonathan Cameron <jic23@cam.ac.uk>
> > 
> > While this driver is placed in IIO within staging at the moment, these
> > changes are definitely input related.  Hence I have cc'd Dmitry and the
> > input list.
> > 
> > I am personaly a little uncomfortable that we have such a complex bit of
> > input code sat within an IIO driver but such is life.
> 
> Maybe an MFD for this ADC unit would be a better way to go? Currently I
> have a different problem with this driver, because the ADC unit monitors
> the battery as well. And the charging driver from the power subsystem
> needs these values to charge the battery in a correct manner.

Are you planning to post the power block patches too ?

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection
Date: Mon, 16 Sep 2013 16:23:48 +0200	[thread overview]
Message-ID: <201309161623.48247.marex@denx.de> (raw)
In-Reply-To: <201309161010.22151.jbe@pengutronix.de>

Dear J?rgen Beisert,

> Hi Jonathan,
> 
> On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> > > For battery driven systems it is a very bad idea to collect the
> > > touchscreen data within a kernel busy loop.
> > > 
> > > This change uses the features of the hardware to delay and accumulate
> > > samples in hardware to avoid a high interrupt and CPU load.
> > > 
> > > Note: this is only tested on an i.MX23 SoC yet.
> > > 
> > > Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> > > CC: linux-arm-kernel at lists.infradead.org
> > > CC: devel at driverdev.osuosl.org
> > > CC: Marek Vasut <marex@denx.de>
> > > CC: Fabio Estevam <fabio.estevam@freescale.com>
> > > CC: Jonathan Cameron <jic23@cam.ac.uk>
> > 
> > While this driver is placed in IIO within staging at the moment, these
> > changes are definitely input related.  Hence I have cc'd Dmitry and the
> > input list.
> > 
> > I am personaly a little uncomfortable that we have such a complex bit of
> > input code sat within an IIO driver but such is life.
> 
> Maybe an MFD for this ADC unit would be a better way to go? Currently I
> have a different problem with this driver, because the ADC unit monitors
> the battery as well. And the charging driver from the power subsystem
> needs these values to charge the battery in a correct manner.

Are you planning to post the power block patches too ?

Best regards,
Marek Vasut

  parent reply	other threads:[~2013-09-16 14:23 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11  8:18 [RFCv4] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-11  8:18 ` Juergen Beisert
2013-09-11  8:18 ` [PATCH 1/6] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert
2013-09-11  8:18 ` [PATCH 2/6] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert
2013-09-15 10:27   ` Jonathan Cameron
2013-09-15 10:27     ` Jonathan Cameron
2013-09-11  8:18 ` [PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert
2013-09-15 10:35   ` Jonathan Cameron
2013-09-15 10:35     ` Jonathan Cameron
2013-09-16  8:17     ` Jürgen Beisert
2013-09-16  8:17       ` Jürgen Beisert
2013-09-16 18:39       ` Jonathan Cameron
2013-09-16 18:39         ` Jonathan Cameron
2013-09-16 14:15   ` Marek Vasut
2013-09-16 14:15     ` Marek Vasut
2013-09-11  8:18 ` [PATCH 4/6] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert
2013-09-15 10:50   ` Jonathan Cameron
2013-09-15 10:50     ` Jonathan Cameron
2013-09-16  8:14     ` Jürgen Beisert
2013-09-16  8:14       ` Jürgen Beisert
2013-09-16 14:19       ` Marek Vasut
2013-09-16 14:19         ` Marek Vasut
2013-09-11  8:18 ` [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert
     [not found]   ` <1378887511-24530-6-git-send-email-jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-09-15 10:56     ` Jonathan Cameron
2013-09-15 10:56       ` Jonathan Cameron
2013-09-15 10:56       ` Jonathan Cameron
     [not found]       ` <52359259.8010202-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-15 16:10         ` Jonathan Cameron
2013-09-15 16:10           ` Jonathan Cameron
2013-09-15 16:10           ` Jonathan Cameron
     [not found]           ` <5235DBEA.7030402-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-16  8:38             ` Jürgen Beisert
2013-09-16  8:38               ` Jürgen Beisert
2013-09-16  8:38               ` Jürgen Beisert
2013-09-16  8:10         ` Jürgen Beisert
2013-09-16  8:10           ` Jürgen Beisert
2013-09-16  8:10           ` Jürgen Beisert
     [not found]           ` <201309161010.22151.jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-09-16  9:37             ` Jürgen Beisert
2013-09-16  9:37               ` Jürgen Beisert
2013-09-16  9:37               ` Jürgen Beisert
2013-09-16 14:23             ` Marek Vasut [this message]
2013-09-16 14:23               ` Marek Vasut
2013-09-16 14:23               ` Marek Vasut
     [not found]               ` <201309161623.48247.marex-ynQEQJNshbs@public.gmane.org>
2013-09-16 14:34                 ` Jürgen Beisert
2013-09-16 14:34                   ` Jürgen Beisert
2013-09-16 14:34                   ` Jürgen Beisert
2013-09-16 15:10                   ` Marek Vasut
2013-09-16 15:10                     ` Marek Vasut
2013-09-16 15:10                     ` Marek Vasut
2013-09-16 15:30             ` Jonathan Cameron
2013-09-16 15:30               ` Jonathan Cameron
2013-09-16 15:30               ` Jonathan Cameron
     [not found]               ` <0fb59809-c835-49b0-bd82-e791db1a9db7-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2013-09-19 12:49                 ` Jürgen Beisert
2013-09-19 12:49                   ` Jürgen Beisert
2013-09-19 12:49                   ` Jürgen Beisert
     [not found]                   ` <201309191449.37274.jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-09-19 16:12                     ` Jonathan Cameron
2013-09-19 16:12                       ` Jonathan Cameron
2013-09-19 16:12                       ` Jonathan Cameron
2013-09-16 15:28         ` Dmitry Torokhov
2013-09-16 15:28           ` Dmitry Torokhov
2013-09-16 15:28           ` Dmitry Torokhov
     [not found]           ` <20130916152846.GC12105-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2013-09-17  7:33             ` Jürgen Beisert
2013-09-17  7:33               ` Jürgen Beisert
2013-09-17  7:33               ` Jürgen Beisert
2013-09-11  8:18 ` [PATCH 6/6] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-11  8:18   ` Juergen Beisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309161623.48247.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=otavio.salvador-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.