From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Date: Mon, 16 Sep 2013 16:23:48 +0200 Message-ID: <201309161623.48247.marex@denx.de> References: <1378887511-24530-1-git-send-email-jbe@pengutronix.de> <52359259.8010202@kernel.org> <201309161010.22151.jbe@pengutronix.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201309161010.22151.jbe-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?iso-8859-1?q?J=FCrgen_Beisert?= Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jonathan Cameron , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, Torokhov , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Otavio Salvador List-Id: linux-input@vger.kernel.org Dear J=FCrgen Beisert, > Hi Jonathan, >=20 > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > On 09/11/13 09:18, Juergen Beisert wrote: > > > For battery driven systems it is a very bad idea to collect the > > > touchscreen data within a kernel busy loop. > > >=20 > > > This change uses the features of the hardware to delay and accumu= late > > > samples in hardware to avoid a high interrupt and CPU load. > > >=20 > > > Note: this is only tested on an i.MX23 SoC yet. > > >=20 > > > Signed-off-by: Juergen Beisert > > > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > > CC: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org > > > CC: Marek Vasut > > > CC: Fabio Estevam > > > CC: Jonathan Cameron > >=20 > > While this driver is placed in IIO within staging at the moment, th= ese > > changes are definitely input related. Hence I have cc'd Dmitry and= the > > input list. > >=20 > > I am personaly a little uncomfortable that we have such a complex b= it of > > input code sat within an IIO driver but such is life. >=20 > Maybe an MFD for this ADC unit would be a better way to go? Currently= I > have a different problem with this driver, because the ADC unit monit= ors > the battery as well. And the charging driver from the power subsystem > needs these values to charge the battery in a correct manner. Are you planning to post the power block patches too ? Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net ([212.18.0.10]:59852 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518Ab3IPOXw convert rfc822-to-8bit (ORCPT ); Mon, 16 Sep 2013 10:23:52 -0400 From: Marek Vasut To: =?iso-8859-1?q?J=FCrgen_Beisert?= Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Date: Mon, 16 Sep 2013 16:23:48 +0200 Cc: linux-arm-kernel@lists.infradead.org, Jonathan Cameron , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, fabio.estevam@freescale.com, jic23@cam.ac.uk, Torokhov , "linux-input@vger.kernel.org" , Otavio Salvador References: <1378887511-24530-1-git-send-email-jbe@pengutronix.de> <52359259.8010202@kernel.org> <201309161010.22151.jbe@pengutronix.de> In-Reply-To: <201309161010.22151.jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201309161623.48247.marex@denx.de> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Dear Jürgen Beisert, > Hi Jonathan, > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > On 09/11/13 09:18, Juergen Beisert wrote: > > > For battery driven systems it is a very bad idea to collect the > > > touchscreen data within a kernel busy loop. > > > > > > This change uses the features of the hardware to delay and accumulate > > > samples in hardware to avoid a high interrupt and CPU load. > > > > > > Note: this is only tested on an i.MX23 SoC yet. > > > > > > Signed-off-by: Juergen Beisert > > > CC: linux-arm-kernel@lists.infradead.org > > > CC: devel@driverdev.osuosl.org > > > CC: Marek Vasut > > > CC: Fabio Estevam > > > CC: Jonathan Cameron > > > > While this driver is placed in IIO within staging at the moment, these > > changes are definitely input related. Hence I have cc'd Dmitry and the > > input list. > > > > I am personaly a little uncomfortable that we have such a complex bit of > > input code sat within an IIO driver but such is life. > > Maybe an MFD for this ADC unit would be a better way to go? Currently I > have a different problem with this driver, because the ADC unit monitors > the battery as well. And the charging driver from the power subsystem > needs these values to charge the battery in a correct manner. Are you planning to post the power block patches too ? Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Mon, 16 Sep 2013 16:23:48 +0200 Subject: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection In-Reply-To: <201309161010.22151.jbe@pengutronix.de> References: <1378887511-24530-1-git-send-email-jbe@pengutronix.de> <52359259.8010202@kernel.org> <201309161010.22151.jbe@pengutronix.de> Message-ID: <201309161623.48247.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear J?rgen Beisert, > Hi Jonathan, > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > On 09/11/13 09:18, Juergen Beisert wrote: > > > For battery driven systems it is a very bad idea to collect the > > > touchscreen data within a kernel busy loop. > > > > > > This change uses the features of the hardware to delay and accumulate > > > samples in hardware to avoid a high interrupt and CPU load. > > > > > > Note: this is only tested on an i.MX23 SoC yet. > > > > > > Signed-off-by: Juergen Beisert > > > CC: linux-arm-kernel at lists.infradead.org > > > CC: devel at driverdev.osuosl.org > > > CC: Marek Vasut > > > CC: Fabio Estevam > > > CC: Jonathan Cameron > > > > While this driver is placed in IIO within staging at the moment, these > > changes are definitely input related. Hence I have cc'd Dmitry and the > > input list. > > > > I am personaly a little uncomfortable that we have such a complex bit of > > input code sat within an IIO driver but such is life. > > Maybe an MFD for this ADC unit would be a better way to go? Currently I > have a different problem with this driver, because the ADC unit monitors > the battery as well. And the charging driver from the power subsystem > needs these values to charge the battery in a correct manner. Are you planning to post the power block patches too ? Best regards, Marek Vasut