From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Vasut To: "Lars-Peter Clausen" Subject: Re: [PATCH 25/27] staging:iio:mxs-lradc: Use iio_push_to_buffers_with_timestamp() Date: Mon, 16 Sep 2013 19:08:05 +0200 Cc: Jonathan Cameron , linux-iio@vger.kernel.org, Fabio Estevam References: <1379263880-18405-1-git-send-email-lars@metafoo.de> <201309161553.34371.marex@denx.de> <523737B0.9080306@metafoo.de> In-Reply-To: <523737B0.9080306@metafoo.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Message-Id: <201309161908.05417.marex@denx.de> List-ID: Dear Lars-Peter Clausen, > On 09/16/2013 03:53 PM, Marek Vasut wrote: > > Dear Lars-Peter Clausen, > > > >> Makes the code a bit shorter and less ugly. > >> > >> Signed-off-by: Lars-Peter Clausen > >> Cc: Fabio Estevam > >> Cc: Marek Vasut > >> --- > >> > >> drivers/staging/iio/adc/mxs-lradc.c | 8 +------- > >> 1 file changed, 1 insertion(+), 7 deletions(-) > >> > >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c > >> b/drivers/staging/iio/adc/mxs-lradc.c index 7401230..9da64bf 100644 > >> --- a/drivers/staging/iio/adc/mxs-lradc.c > >> +++ b/drivers/staging/iio/adc/mxs-lradc.c > >> @@ -625,13 +625,7 @@ static irqreturn_t mxs_lradc_trigger_handler(int > >> irq, void *p) j++; > >> > >> } > >> > >> - if (iio->scan_timestamp) { > >> - s64 *timestamp = (s64 *)((u8 *)lradc->buffer + > >> - ALIGN(j, sizeof(s64))); > >> - *timestamp = pf->timestamp; > >> - } > >> - > >> - iio_push_to_buffers(iio, lradc->buffer); > >> + iio_push_to_buffers_with_timestamp(iio, lradc->buffer, pf->timestamp); > >> > >> iio_trigger_notify_done(iio->trig); > > > > Indeed, this stuff was duplicated all around. > > Is that a acked-by? :) Reviewed-by: Marek Vasut instead. I'm not on too firm ground here, so I don't feel like ack is appropriate from me on this matter ;-) Best regards, Marek Vasut