Re: [PATCH 2/3] kernel.bbclass: Pull in tweaks from oe-core patch to local copy

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Sep 16, 2013 at 03:12:50PM -0400, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Monday, September 09, 2013 1:22 PM
> > To: Cooper Jr., Franklin
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 2/3] kernel.bbclass: Pull in tweaks from oe-
> > core patch to local copy
> > 
> > On Mon, Sep 09, 2013 at 12:29:30PM -0500, Franklin S. Cooper Jr wrote:
> > > The below patch has been submitted to oe-core. Modify local copy of
> > > kernel.bbclass to mimic this patch until patch is upstreamed.
> > 
> > Have you addressed the latest comments for the upstream patch:
> > 
> > http://thread.gmane.org/gmane.comp.handhelds.openembedded.core/41748/
> > focus=41752
> [Franklin] 
> Nope somehow I missed that comment. I'll submit an updated version.
> > 
> > I would prefer to avoid overlaying a complete class locally just for this simple fix.
> > Having a smaller bbappend with do_install_append() seems like a less intrusive
> > change... Comments?

> [Franklin] Based on the comment to my patch in oe-core the proper approach 
> is to make the change via pkg_postinst. If appending/prepending a 
> pkg_postinst is possible then I have no issue not overlaying the entire 

Shouldn't be a problem - we've done it before ourselves:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-graphics/libgles/libgles-omap3.inc#n404

And here's an example from meta-oe:
http://cgit.openembedded.org/cgit.cgi/meta-openembedded/tree/meta-gnome/recipes-gnome/gnome-panel/gnome-panel3_3.0.2.bb?h=master#n34


> class. Since this change would be a per recipe change is there any reason 
> not to directly modify the recipe in meta-ti to incorporate this change 
> instead of having an append in meta-arago?

It seems like a generic change, so meta-ti should be fine. Unfortunately, we 
deprecated use of generic linux.inc...


> > > kernel.bbclass: Create symbolic link to add ${KERNEL_IMAGETYPE} to
> > > boot package
> > > * By default for some platforms U-boot assumes the kernel image is located in
> > >   the boot directory of the root filesystem.
> > > * The kernel.bbclass already includes the kernel image in the /boot directory
> > >   but adds a version number to the file name.
> > > * Create a symbolic link that names the kernel image in the exact way that
> > >   U-boot expects.
> > >
> > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > ---
> > >  meta-arago-distro/classes/kernel.bbclass |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/classes/kernel.bbclass
> > > b/meta-arago-distro/classes/kernel.bbclass
> > > index 3320747..1211911 100644
> > > --- a/meta-arago-distro/classes/kernel.bbclass
> > > +++ b/meta-arago-distro/classes/kernel.bbclass
> > > @@ -109,6 +109,7 @@ kernel_do_install() {
> > >  	install -d ${D}/${KERNEL_IMAGEDEST}
> > >  	install -d ${D}/boot
> > >  	install -m 0644 ${KERNEL_OUTPUT}
> > > ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION}
> > > +	ln      -sf ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-
> > ${KERNEL_VERSION} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}
> > >  	install -m 0644 System.map ${D}/boot/System.map-
> > ${KERNEL_VERSION}
> > >  	install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION}
> > >  	install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION}
> > > --
> > > 1.7.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago