Re: [RESEND PATCH v5 1/4] mm/vmalloc: don't set area->caller twice

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

Hi KOSAKI,
On Mon, Sep 16, 2013 at 03:52:31PM -0400, KOSAKI Motohiro wrote:
>On 9/14/2013 7:45 PM, Wanpeng Li wrote:
>> Changelog:
>>  *v1 -> v2: rebase against mmotm tree
>> 
>> The caller address has already been set in set_vmalloc_vm(), there's no need
>
>                                            setup_vmalloc_vm()
>

Thanks.

>> to set it again in __vmalloc_area_node.
>> 
>> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>>  mm/vmalloc.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index 1074543..d78d117 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
>>  		pages = kmalloc_node(array_size, nested_gfp, node);
>>  	}
>>  	area->pages = pages;
>> -	area->caller = caller;
>>  	if (!area->pages) {
>>  		remove_vm_area(area->addr);
>>  		kfree(area);
>
>Then, __vmalloc_area_node() no longer need "caller" argument. It can use area->caller instead.
>

Thanks for pointing out, I will update it in next version. 

Regards,
Wanpeng Li 

>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>