From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks Date: Tue, 17 Sep 2013 10:22:23 +0100 Message-ID: <20130917092223.GA32230@strange.amr.corp.intel.com> References: <1378493845-476-1-git-send-email-damien.lespiau@intel.com> <1378493845-476-8-git-send-email-damien.lespiau@intel.com> <20130916173512.GA29268@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id A26C1E7212 for ; Tue, 17 Sep 2013 02:22:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130916173512.GA29268@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Joakim Plate Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Sep 16, 2013 at 06:35:12PM +0100, Damien Lespiau wrote: > On Fri, Sep 13, 2013 at 04:10:24PM +0000, Joakim Plate wrote: > > Damien Lespiau intel.com> writes: > > > > > +static const struct s3d_mandatory_mode s3d_mandatory_modes[] = { > > > + { 1920, 1080, 24, 0, > > > + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING > > }, > > > + { 1920, 1080, 50, DRM_MODE_FLAG_INTERLACE, > > > + DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF }, > > > + { 1920, 1080, 60, DRM_MODE_FLAG_INTERLACE, > > > + DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF }, > > > + { 1280, 720, 50, 0, > > > + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING > > }, > > > + { 1280, 720, 60, 0, > > > + DRM_MODE_FLAG_3D_TOP_AND_BOTTOM | DRM_MODE_FLAG_3D_FRAME_PACKING } > > > +}; > > > > > > I may be missing something here... But.. > > Oops, did not see your answer, please don't forget to include me in Cc: > next time and not just the list. > > > The frame packed modes are much higher in pixels than this and include frame > > packing. > > 1080*2+45=2050 > > 720*2+30=1470 > > > > Unless you intend to hide the left/right split in mesa or other place, we > > need to get the ability to render to both fields somehow. > > > > Either as the full 2050 pixels high or at 1080*2 and the driver adds the > > blanking. > > Right, so at the moment, my proposition is that userspace is responsible for > giving us a framebuffer with the right dimensions. For instance in > intel-gpu-tools's testdisplay I have: [...] > and then adjust the timings if needed: So, actually it seems that this will change a bit. User space still needs to compute a correct fb size. In the case of frame packing, note that user-space also needs to add the vblank lines, because it has to know where to place the second eye starting at vdisplay + vblank. The kernel will be in charge of tweaking the timings if needed though, see: http://lists.freedesktop.org/archives/dri-devel/2013-September/045386.html -- Damien ~