From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device request macros from EHCI header
Date: Tue, 17 Sep 2013 17:23:35 +0200 [thread overview]
Message-ID: <201309171723.35717.marex@denx.de> (raw)
In-Reply-To: <CAFp+6iHz7tC+p4JxNG=fJBru=A7Wkp34nVpky1ZrcNqx+vvrvQ@mail.gmail.com>
Dear Vivek Gautam,
> Hi Marek,
>
> On Tue, Sep 17, 2013 at 8:32 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> >
> >> Macros defining bmRequestType field of USB device request,
> >> given in table 9.2 USB 2.0 spec, are rather generic macros
> >> which can be further used by other Host controller stacks.
> >> So moving them to usb_defs header.
> >>
> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> >> Cc: Julius Werner <jwerner@chromium.org>
> >> Cc: Simon Glass <sjg@chromium.org>
> >> Cc: Minkyu Kang <mk7.kang@samsung.com>
> >> Cc: Dan Murphy <dmurphy@ti.com>
> >> Cc: Marek Vasut <marex@denx.de>
> >
> > Why not just use include/usb.h ?
>
> The bit field definitions for usb-types usb-recipient, and directions
> are itself defined in usb_defs.h;
> so i thought of keeping their combination just below it, so that it
> would not be difficult to reference.
>
> Please let me know if you want me to move them to include/usb.h
Ah, we already have usb_defs.h , then this is OK. The headers are mess and will
eventually need cleanup too, not in this patchset of course.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-17 15:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 8:32 [U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device request macros from EHCI header Vivek Gautam
2013-09-17 3:02 ` Marek Vasut
2013-09-17 3:21 ` Vivek Gautam
2013-09-17 15:23 ` Marek Vasut [this message]
2013-09-14 8:32 ` [U-Boot] [PATCH v3 02/10] USB: xHCI: Add stack support for xHCI Vivek Gautam
2013-09-23 12:50 ` Dan Murphy
2013-09-23 15:10 ` Marek Vasut
2013-09-14 8:32 ` [U-Boot] [PATCH v3 03/10] USB: XHCI: Add xHCI host controller support for Exynos5 Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 04/10] arm: exynos: Add methods to control power to USB 3.0 PHY Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 05/10] exynos5: dts: Add COMPAT string data for USB 3.0 PHY and XHCI Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 06/10] exynos5: dts: Add device node for XHCI Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 07/10] config: arm: exynos5250: Define CONFIG_SYS_CACHELINE_SIZE Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 08/10] temp: config: exynos5250: Enable xHCI support for Exynos5 Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 09/10] exynos: usb: Switch USB VBUS GPIOs to be device tree configured Vivek Gautam
2013-09-14 8:32 ` [U-Boot] [PATCH v3 10/10] exynos: dts: Add USB VBUS GPIOs to the device tree Vivek Gautam
2013-09-14 9:10 ` [U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver Vivek Gautam
2013-09-17 3:07 ` Marek Vasut
2013-09-17 13:12 ` Minkyu Kang
2013-09-23 15:29 ` Marek Vasut
2013-09-23 18:01 ` Dan Murphy
2013-09-24 15:54 ` Marek Vasut
2013-09-24 1:53 ` Vivek Gautam
2013-09-24 7:00 ` Marek Vasut
2013-09-24 8:50 ` Vivek Gautam
2013-09-25 15:46 ` Dan Murphy
2013-09-27 14:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309171723.35717.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.