From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1VLz16-0000OU-Um
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:24:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1VLz12-0005B7-BD
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:24:48 -0400
Received: from ssl.serverraum.org ([88.198.40.39]:52389)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1VLz11-0005Ai-Se
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:24:44 -0400
From: Michael Walle <michael@walle.cc>
Date: Tue, 17 Sep 2013 19:24:38 +0200
References: <1377969760-17489-1-git-send-email-antonynpavlov@gmail.com>
	<1377969760-17489-2-git-send-email-antonynpavlov@gmail.com>
	<CAEgOgz74_YfHhc3FSR2YnjrzT7quAiZq8eb+M3zGPomEvh_mdg@mail.gmail.com>
In-Reply-To: <CAEgOgz74_YfHhc3FSR2YnjrzT7quAiZq8eb+M3zGPomEvh_mdg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201309171924.38664.michael@walle.cc>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use
	qemu_chr_fe_write_all() instead of qemu_chr_fe_write()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Antony Pavlov <antonynpavlov@gmail.com>, Andreas =?iso-8859-1?q?F=E4rber?= <afaerber@suse.de>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Am Montag, 2. September 2013, 00:58:42 schrieb Peter Crosthwaite:
> On Sun, Sep 1, 2013 at 3:22 AM, Antony Pavlov <antonynpavlov@gmail.com>=20
wrote:
> > qemu_chr_fe_write() is capable of returning 0
> > to indicate EAGAIN (and friends) and we don't
> > handle this.
> >=20
> > Just change it to qemu_chr_fe_write_all() to fix.
> >=20
> > Reported-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>=20
> Acked-by Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>=20
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > CC: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> > CC: Michael Walle <michael@walle.cc>
> > CC: Andreas F=E4rber <afaerber@suse.de>
> > ---
> >=20
> >  hw/char/milkymist-uart.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
> > index 2e4b5c5..6e4bc20 100644
> > --- a/hw/char/milkymist-uart.c
> > +++ b/hw/char/milkymist-uart.c
> > @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr,
> > uint64_t value,
> >=20
> >      switch (addr) {
> >     =20
> >      case R_RXTX:
> >          if (s->chr) {
> >=20
> > -            qemu_chr_fe_write(s->chr, &ch, 1);
> > +            qemu_chr_fe_write_all(s->chr, &ch, 1);
> >=20
> >          }
> >          s->regs[R_STAT] |=3D STAT_TX_EVT;
> >          break;
> >=20
> > --
> > 1.8.4.rc3

I'll pick this one. Thank you.

=2D-=20
michael