From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1965649949704333108==" MIME-Version: 1.0 From: Sergey Senozhatsky Subject: Re: [Powertop] [PATCH] embed self-contained javascript Date: Tue, 17 Sep 2013 22:41:29 +0300 Message-ID: <20130917194129.GD2289@swordfish> In-Reply-To: 5238AD14.5060200@fifthhorseman.net To: powertop@lists.01.org List-ID: --===============1965649949704333108== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On (09/17/13 15:27), Daniel Kahn Gillmor wrote: > On 09/17/2013 03:02 PM, Sergey Senozhatsky wrote: > > there is a number of trailing whitespaces, could you please fix that? > = > sure, see the attached patch. > = > > can we also use one coding style in js code? > > = > > if (a) > > a-foo; > > = > > if (b) { > > b-foo; > > b-bar; > > } > = > It's not clear to me if you're suggesting only that the then clause > needs to be on a separate line (instead of one-liners), or if you're > suggesting that single-line if statements should also have curly brackets. sorry, the first one: then clause needs to be on a separate line. > The attached patch assumes that the former was your intent; if you want > curly-brackets on single-line if statements, let me know and i'll send > you v3 with that adjustment. looks good. applied to -next, thanks. -ss > thanks for your consideration. > = > Regards, > = > --dkg > commit b332a57a43d79b030a4de1dbd2f235c808d71c31 > Author: Daniel Kahn Gillmor > Date: Sat Sep 7 15:42:57 2013 -0400 > = > embed self-contained javascript > = > using self-contained javascript offers several improvements: > = > * powertop html report can be viewed offline > * less overall javascript code is loaded when online > * no opportunity for report leakage or modification by third parties > = > These changes also make it simpler to update the html report when a > new section is added: just add a new entry to powertop.blocks > dictionary, with the section's human-readable string as its value. > = > diff --git a/src/powertop.css b/src/powertop.css > index c73d3e2..6d43e07 100644 > --- a/src/powertop.css > +++ b/src/powertop.css > @@ -3,276 +3,73 @@ > > PowerTOP report > > - > - > - > > = > - > - > + >
> -

 

>
> = --===============1965649949704333108==--