All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Kirkwood - Remove kirkwood_setup_wins and rely on the DT binding
Date: Tue, 17 Sep 2013 20:03:01 +0200	[thread overview]
Message-ID: <20130917200301.66e8ccb9@skate> (raw)
In-Reply-To: <20130917153619.GA14098@obsidianresearch.com>

Dear Jason Gunthorpe,

On Tue, 17 Sep 2013 09:36:19 -0600, Jason Gunthorpe wrote:

> Since they are all the same I'll respin the patch and add the ranges
> to the kirkwood.dtsi and remove it from all the board files, (which is
> where I started, but then saw that board files had a ranges
> already)

In Armada 370/XP land, we've decided to always put the ranges in the
per-board .dts file. The reason is that sometimes, a board needs to add
an additional range (like for a NOR device for example), and
unfortunately, the existing DT language doesn't allow "extending"
a 'ranges' property defined at the .dtsi level by an additional entry
added at the .dts level.

This has lead to problems in Armada 370/XP land, where we were
overloading the ranges property for some boards in the .dts, then added
a new range in the .dtsi, and forgot to propagate this change to
the .dts files. To avoid this, we've decided to have the ranges
property always in the .dts files.

A better solution would be to have a += operator in the DT language,
but until that exists, we thought that pushing the ranges property down
to the .dts file was the least horrible solution.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-09-17 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 22:47 [PATCH] arm: Kirkwood - Remove kirkwood_setup_wins and rely on the DT binding Jason Gunthorpe
2013-09-17 13:32 ` Ezequiel Garcia
2013-09-17 15:36   ` Jason Gunthorpe
2013-09-17 18:03     ` Thomas Petazzoni [this message]
2013-09-17 18:17       ` Jason Gunthorpe
2013-09-17 18:25         ` Ezequiel Garcia
2013-09-17 18:48         ` Sebastian Hesselbarth
2013-09-17 18:58         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917200301.66e8ccb9@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.