All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] Fix EGL support in qt5base
Date: Tue, 17 Sep 2013 20:33:13 +0200	[thread overview]
Message-ID: <20130917203313.0da278a9@skate> (raw)
In-Reply-To: <1379411589-8935-1-git-send-email-jezz@sysmic.org>

Dear J?r?me Pouiller,

On Tue, 17 Sep 2013 11:53:09 +0200, J?r?me Pouiller wrote:
> For many EGL libraries, Qt5 need special instructions to compile correctly. 
> This patch implement a more generic way to customize Qt5 compilation.
> 
> In add, it fix support for Rasberry Pi and Vivante GPUs.
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

I'm sorry, but this really looks ugly, and doesn't seem needed at all.
We already have a working solution for this problem (which we already
had for the RPi, and we solved in a much nicer way I believe) :

 (1) The OpenGL implementation should install proper pkg-config files
     to allow Qt5 to get the right compilation flags/libraries. See the
     "gpu-viv-bin-mx6q: add pkgconfig files for EGL and OpenGLESv2"
     patch that Fatih has sent today.

 (2) We already have a mechanism in qt5.mk to customize the EGL
     platform hook implementation. It just need to be extended to cover
     the i.MX6 case. I.e, next to:

ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
        $(@D)/mkspecs/devices/linux-rasp-pi-g++/qeglfshooks_pi.cpp
endif

     one should add:

ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y)
QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
	$(@D)/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp
endif

If someone makes a patch with both of these changes, then it'll have my
Acked-by.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-09-17 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  7:37 [Buildroot] Fix to Qt5base-build Espen Frimann Koren
2013-09-17  9:53 ` [Buildroot] [PATCH v1] Fix EGL support in qt5base Jérôme Pouiller
2013-09-17 11:35   ` Fatih Aşıcı
2013-09-17 18:33   ` Thomas Petazzoni [this message]
2013-09-18 11:13     ` Jérôme Pouiller
2013-09-18 16:27       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917203313.0da278a9@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.