From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: xfs directory unbalance assert test
Date: Wed, 18 Sep 2013 07:29:17 +1000 [thread overview]
Message-ID: <20130917212917.GK19103@dastard> (raw)
In-Reply-To: <20130917145959.333796933@sgi.com>
On Tue, Sep 17, 2013 at 09:59:47AM -0500, Mark Tinguely wrote:
> +# Fill the filesystem.
> +FSSTRESS_ARGS="-z -s 1378390208 -fsymlink=1 -n7500000 -p4 -d $SCRATCH_MNT"
> +$FSSTRESS_PROG $FSSTRESS_ARGS >> $seqres.full 2>&1
> +
> +cd $SCRATCH_MNT >> $seqres.full 2>&1
> +sync
> +# A debug XFS may assert in the remove due to a directory bug.
> +rm -rf *
Wouldn't this be better:
sync
rm -rf $SCRATCH_MNT/*
Remember, xfstests runs as root and so having a "rm -rf *" anywhere
in a test is a disaster just waiting to happen....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-09-17 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130917145946.124195107@sgi.com>
2013-09-17 14:59 ` [PATCH] xfstests: xfs directory unbalance assert test Mark Tinguely
2013-09-17 15:28 ` Eryu Guan
2013-09-17 15:48 ` Mark Tinguely
2013-09-17 15:51 ` Eric Sandeen
2013-09-17 16:00 ` Mark Tinguely
2013-09-17 15:41 ` Eric Sandeen
2013-09-17 15:58 ` Mark Tinguely
2013-09-17 16:06 ` Eric Sandeen
2013-09-17 21:29 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917212917.GK19103@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.