From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 18 Sep 2013 17:20:55 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:51688 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6825760Ab3IRPUuNMS9I (ORCPT ); Wed, 18 Sep 2013 17:20:50 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id r8IFKm6T000319; Wed, 18 Sep 2013 17:20:48 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id r8IFKlxI000316; Wed, 18 Sep 2013 17:20:47 +0200 Date: Wed, 18 Sep 2013 17:20:47 +0200 From: Ralf Baechle To: "Steven J. Hill" Cc: linux-mips@linux-mips.org, Leonid Yegoshin Subject: Re: [PATCH] MIPS: Fix VGA_MAP_MEM macro. Message-ID: <20130918152047.GR22468@linux-mips.org> References: <1378859764-17544-1-git-send-email-Steven.Hill@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378859764-17544-1-git-send-email-Steven.Hill@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37873 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Sep 10, 2013 at 07:36:04PM -0500, Steven J. Hill wrote: > diff --git a/arch/mips/include/asm/vga.h b/arch/mips/include/asm/vga.h > index f4cff7e..4795206 100644 > --- a/arch/mips/include/asm/vga.h > +++ b/arch/mips/include/asm/vga.h > @@ -13,7 +13,7 @@ > * access the videoram directly without any black magic. > */ > > -#define VGA_MAP_MEM(x, s) (0xb0000000L + (unsigned long)(x)) > +#define VGA_MAP_MEM(x, s) CKSEG1ADDR(0x10000000L + (unsigned long)(x)) If using an addrspace.h macro better include that header file! I've fixed that. Applied. Thanks! Ralf