All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net: fec_mxc: Fix timeouts during tftp transfer
Date: Wed, 18 Sep 2013 17:32:06 +0200	[thread overview]
Message-ID: <201309181732.06996.marex@denx.de> (raw)
In-Reply-To: <1379470390-19279-1-git-send-email-festevam@gmail.com>

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Performing tftp transfers on mx28 results in random timeouts.
> 
> Hector Palacios and Robert Hodaszi analyzed the root cause being related to
> the wrong alignment of the 'buff' buffer inside fec_recv().
> 
> Beno?t Th?baudeau provided an excellent analysis of the alignment bug that
> is present on older versions, such as GCC 4.5.4:
> 
> http://marc.info/?l=u-boot&m=137942904906131&w=2
> 
> Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC
> versions.
> 
> Reported-by: Hector Palacios <hector.palacios@digi.com>
> Tested-by: Oliver Metz <oliver@freetz.org>
> Tested-by: Hector Palacios <hector.palacios@digi.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Improve commit log
> - Add Hector's Tested-by tag
> 
>  drivers/net/fec_mxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Marek Vasut <marex@denx.de>
Tested-by: Marek Vasut <marex@denx.de>

Stefano, can you please apply for .10 ?

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-18 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18  2:13 [U-Boot] [PATCH v2] net: fec_mxc: Fix timeouts during tftp transfer Fabio Estevam
2013-09-18 15:32 ` Marek Vasut [this message]
2013-09-20 16:11 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309181732.06996.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.