From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Wed, 18 Sep 2013 15:26:43 -0700 [thread overview]
Message-ID: <20130918222642.GK9994@atomide.com> (raw)
In-Reply-To: <1379541145-25934-1-git-send-email-pali.rohar@gmail.com>
* Pali Rohár <pali.rohar@gmail.com> [130918 15:02]:
> Without max_current data in board file lp5523 driver does not change current.
Hmm is this a regression or are there other reasons to merge
this during the -rc cycle?
Regards,
Tony
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 9326890..d0f857c 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -180,38 +180,47 @@ static struct lp55xx_led_config rx51_lp5523_led_config[] = {
> .name = "lp5523:kb1",
> .chan_nr = 0,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb2",
> .chan_nr = 1,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb3",
> .chan_nr = 2,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb4",
> .chan_nr = 3,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:b",
> .chan_nr = 4,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:g",
> .chan_nr = 5,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:r",
> .chan_nr = 6,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb5",
> .chan_nr = 7,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb6",
> .chan_nr = 8,
> .led_current = 50,
> + .max_current = 255,
> }
> };
>
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Wed, 18 Sep 2013 15:26:43 -0700 [thread overview]
Message-ID: <20130918222642.GK9994@atomide.com> (raw)
In-Reply-To: <1379541145-25934-1-git-send-email-pali.rohar@gmail.com>
* Pali Rohár <pali.rohar@gmail.com> [130918 15:02]:
> Without max_current data in board file lp5523 driver does not change current.
Hmm is this a regression or are there other reasons to merge
this during the -rc cycle?
Regards,
Tony
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 9326890..d0f857c 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -180,38 +180,47 @@ static struct lp55xx_led_config rx51_lp5523_led_config[] = {
> .name = "lp5523:kb1",
> .chan_nr = 0,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb2",
> .chan_nr = 1,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb3",
> .chan_nr = 2,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb4",
> .chan_nr = 3,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:b",
> .chan_nr = 4,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:g",
> .chan_nr = 5,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:r",
> .chan_nr = 6,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb5",
> .chan_nr = 7,
> .led_current = 50,
> + .max_current = 255,
> }, {
> .name = "lp5523:kb6",
> .chan_nr = 8,
> .led_current = 50,
> + .max_current = 255,
> }
> };
>
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2013-09-18 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 21:52 [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config Pali Rohár
2013-09-18 22:26 ` Tony Lindgren [this message]
2013-09-18 22:26 ` Tony Lindgren
2013-09-19 21:01 ` Pali Rohár
2013-09-19 21:29 ` Tony Lindgren
2013-09-19 21:29 ` Tony Lindgren
2013-09-19 22:20 ` Pali Rohár
2013-09-23 12:50 ` [PATCH v2] " Pali Rohár
2013-09-23 13:06 ` joerg Reisenweber
2013-10-08 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918222642.GK9994@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.