From: Olaf Hering <olaf@aepfle.de>
To: Matthew Daley <mattjd@gmail.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] qemu-traditional: do not strip binaries during make install
Date: Thu, 19 Sep 2013 09:41:48 +0200 [thread overview]
Message-ID: <20130919074148.GA19829@aepfle.de> (raw)
In-Reply-To: <CA+nUz_KVgDbAk_mgsjAh94ABSajHy3FFsRR1juWeCXjRn-V6Ew@mail.gmail.com>
On Thu, Sep 19, Matthew Daley wrote:
> On Thu, Sep 19, 2013 at 6:11 AM, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -243,7 +243,7 @@ endif
> > install: all $(if $(BUILD_DOCS),install-doc)
> > mkdir -p "$(DESTDIR)$(bindir)"
> > ifneq ($(TOOLS),)
> > - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> > endif
> > ifneq ($(BLOBS),)
> > mkdir -p "$(DESTDIR)$(datadir)"
> > diff --git a/Makefile.target b/Makefile.target
> > index 19bb0fd..1cf7f34 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -755,7 +755,7 @@ clean:
> >
> > install: all install-hook
> > ifneq ($(PROGS),)
> > - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
>
> Perhaps it would be worthwhile to only do this if debug=y is set, like
> in commit 8e4610e (which is the equivalent of this patch for
> qemu-xen)?
I dont think any "make install" has to modify the binaries. If debuginfo
was requested by passing "-g" via CFLAGS then the generated debuginfo
has to be preserved during make install.
Olaf
next prev parent reply other threads:[~2013-09-19 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 18:11 [PATCH] qemu-traditional: do not strip binaries during make install Olaf Hering
2013-09-19 0:21 ` Matthew Daley
2013-09-19 7:41 ` Olaf Hering [this message]
2013-10-10 17:19 ` Ian Jackson
2013-10-14 15:29 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 9:42 Olaf Hering
2012-12-05 18:42 Olaf Hering
2013-01-16 15:47 ` Olaf Hering
2013-04-29 13:40 ` Olaf Hering
2013-05-01 16:22 ` Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919074148.GA19829@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=mattjd@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.