From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 4/4] xfs: clean up xfs_inactive() error handling, kill VN_INACTIVE_[NO]CACHE
Date: Fri, 20 Sep 2013 09:50:38 +1000 [thread overview]
Message-ID: <20130919235038.GS9901@dastard> (raw)
In-Reply-To: <1379618121-35105-5-git-send-email-bfoster@redhat.com>
On Thu, Sep 19, 2013 at 03:15:21PM -0400, Brian Foster wrote:
> The xfs_inactive() return value is meaningless. Turn xfs_inactive()
> into a void function and clean up the error handling appropriately.
> Kill the VN_INACTIVE_[NO]CACHE directives as they are not relevant
> to Linux.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-09-19 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 19:15 [PATCH v2 0/4] xfs: rework xfs_inactive() Brian Foster
2013-09-19 19:15 ` [PATCH v2 1/4] xfs: push down inactive transaction mgmt for remote symlinks Brian Foster
2013-09-19 23:42 ` Dave Chinner
2013-09-19 19:15 ` [PATCH v2 2/4] xfs: push down inactive transaction mgmt for truncate Brian Foster
2013-09-19 23:47 ` Dave Chinner
2013-09-19 19:15 ` [PATCH v2 3/4] xfs: push down inactive transaction mgmt for ifree Brian Foster
2013-09-19 23:49 ` Dave Chinner
2013-09-19 19:15 ` [PATCH v2 4/4] xfs: clean up xfs_inactive() error handling, kill VN_INACTIVE_[NO]CACHE Brian Foster
2013-09-19 23:50 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919235038.GS9901@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.